Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(repo): Actually run Next.js integration for v13 & v14 #3516

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

LekoArts
Copy link
Member

@LekoArts LekoArts commented Jun 5, 2024

Description

The PR #3431 was in the correct state at some point but when it was merged the functionality of running the integration tests of Next.js both in Next 13 and 14 actually didn't work.

After reading https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#example-expanding-configurations I think what we had previously won't work.

Proof that Next 13 is used:
https://github.com/clerk/javascript/actions/runs/9379903450/job/25825965337?pr=3516#step:7:91

Proof that Next 14 is used:
https://github.com/clerk/javascript/actions/runs/9379903450/job/25825965564?pr=3516#step:7:89

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Copy link

changeset-bot bot commented Jun 5, 2024

⚠️ No Changeset found

Latest commit: 1e99e7c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@LekoArts LekoArts marked this pull request as ready for review June 5, 2024 07:39
@dimkl
Copy link
Contributor

dimkl commented Jun 5, 2024

@LekoArts based on the ref posted in the description the example contains the windows-latest in os and also includes a variation for the windows-latest os.

        os: [windows-latest, ubuntu-latest]
        node: [14, 16]
        include:
          - os: windows-latest
            node: 16
            npm: 6

I would expect in our case either the 13 or the 14 to be executed twice instead of none 🤔 . Are we sure about this change?
Also the integration tests (nextjs, chrome) in the status checks seem to be stuck.

@LekoArts LekoArts merged commit 206b1d8 into main Jun 5, 2024
17 checks passed
@LekoArts LekoArts deleted the chore/fix-next-e2e-variants branch June 5, 2024 09:22
@LekoArts
Copy link
Member Author

LekoArts commented Jun 5, 2024

I think this happened:

For each object in the include list, the key:value pairs in the object will be added to each of the matrix combinations if none of the key:value pairs overwrite any of the original matrix values. If the object cannot be added to any of the matrix combinations, a new matrix combination will be created instead. Note that the original matrix values will not be overwritten, but added matrix values can be overwritten.

Anyways, we saw it in the PRs not running and in this PR they work, so should be all fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants