-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support VSCode builtin GitHub authentication #1074
Comments
- Install GitHub CLI, despite authentication is not seamless. See cli/cli#1074 - Remove unused code and some comments - Set Prettier as default formatter
- Install GitHub CLI, despite authentication is not seamless. See cli/cli#1074 - Remove unused code and some comments - Set Prettier as default formatter
Hi thank you for letting us know! You bring up a good point that this would make it easier to get going with Unfortunately, I don't think we can piggy-back on VSCode authentication for our needs. First of all, that authentication is probably done via an OAuth app of their own, and we need to connect to our "GitHub CLI" OAuth app for the purposes of ocassionally getting access to some preview APIs. Second of all, we don't know which OAuth scopes does the VSCode authentication request, but since it's only git, it's probably only requests the This is mostly just me guessing, though, and if anybody would be willing to dive into VSCode source and look up how they set up this authentication and link it here, I would be grateful! Ref. #297 |
I'll be honest that workflow in VSCode broke my private key workflow, which in itself was a workaround to their git tooling being only useful for choosing which files to |
@mislav The PR relevant on VS Code: microsoft/vscode#96069 It seems that GitHub Authentication is provided by VS Code to |
If the scope of authentication provided to |
I just had another idea: |
That's not a bad idea in general, but there is still the problem I outlined above: we would generally prefer if |
Not the solution but in case it's useful for anyone; I've found adding a Personal Access Token in the Environment Variables (GITHUB_TOKEN) settings within VS Codespaces has solved this challenge in the short term. |
VSCode now provides GitHub authentication for
git
even in its Terminal.If
gh
had support for that too, we could have a seamless GitHub Authentication when usinggh
inside VSCode, which can mainly benefitvscode-dev-containers
, Visual Studio Codespaces, and therefore, the upcoming GitHub Codespaces.The text was updated successfully, but these errors were encountered: