Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to skip confirmation via a flag #1360

Closed
AliabbasMerchant opened this issue Jul 14, 2020 · 5 comments
Closed

Ability to skip confirmation via a flag #1360

AliabbasMerchant opened this issue Jul 14, 2020 · 5 comments
Labels
enhancement a request to improve CLI

Comments

@AliabbasMerchant
Copy link
Contributor

#1330 proposes to add confirmation to risky commands. It is a nice feature to have, but in order to support proper scriptability, we should support a flag (preferably -y, like in most CLIs), to skip asking for confirmation.
So for each of the 4 commands mentioned there (and possibly even more in the future), we should add support for the -y flag

@ampinsk
Copy link
Contributor

ampinsk commented Jul 14, 2020

Thank you for bringing this up! Let's definitely make sure we ship this alongside #1330 :)

@ShubhankarKG
Copy link
Contributor

@ampinsk , I'd like to ask the exact implementation of the -y flag for gh pr merge, i.e the interactive merge. Do all the options get a default ? Or only the final confirmation gets an affirmative nod ?

Thanks

@ampinsk
Copy link
Contributor

ampinsk commented Jul 20, 2020

@ShubhankarKG I'd say only the final confirmation gets an affirmative, the other pieces already have flags available

@ShubhankarKG
Copy link
Contributor

Okay. Thanks for the leads! I'll incorporate the necessary changes.

@mislav
Copy link
Contributor

mislav commented Sep 4, 2020

@AliabbasMerchant Thanks for bringing this up! I feel that all conversation about confirmation prompts, including an option to skip them, should be happening in #1330, so I'm going to close this one in favor of the original issue. 🙇

@mislav mislav closed this as completed Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement a request to improve CLI
Projects
None yet
Development

No branches or pull requests

5 participants
@mislav @ampinsk @AliabbasMerchant @ShubhankarKG and others