PR Merge confirmations #1622
Merged
PR Merge confirmations #1622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mislav
reviewed
Sep 4, 2020
There was a problem hiding this comment.
Thank you for the feature!
I realize that gh pr merge is mentioned in one of the referenced issues, but I'm not sure if pr merge really needs an additional confirmation step. Right now, pr merge already has a confirmation step:
$ gh pr merge
? What merge method would you like to use?
And instead of passing -y flag, the user can pass one of --merge, --squash, or --rebase as "confirmation". The way I see it, this style of interaction protects from accidental merges but also allows scripting/no-prompt use.
@ampinsk Would you agree?
jameskip
approved these changes
Sep 17, 2020
|
Sorry for the delayed response here! Since this is a "riskier" command that's very high friction to undo, I'd like to include the confirmation and flag. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #1330
Ref #1360
Introducing added confirm step for
pr merge.This step can then be skipped through the
-yflag.