Create repositories from templates in interactive mode

[JunNishimura]

Issue

Existing implementation allows users to create a repository from a template repository using --template flag like below.

gh repo create new-project --template OWNER/REPO --public --clone

But in the interactive mode, cli does not provide options to create a repository from a template repository to users.

It would be better to provide users with a create-with-template option for consistency of functionality and convenience.

Overview

I added Create a new repository on GitHub from a template repository as an option to be displayed when entering interactive mode with gh repo create.

The process of repository creation with a template is below.

1. select Create a new repository on GitHub from a template repository
2. enter repository name
3. select repository owner
4. enter description
5. select visibility
6. select template repository
7. confirmation for the repository creation
8. clone or not

Template repositories tied to the owner is displayed as options. If there is no template repository, an error is output.

Related Issue

• Feature request: add "create from a template" functionality to interactive gh repo create #7744

[williammartin]

Hey @JunNishimura, once again, apologies for not valuing your contribution by letting this sit unreviewed for so long. Generally, this looks like a reasonable approach for a nice addition to the cli.

I have requested a few changes and asked for some clarification on some decisions. I will make it a priority to continue the review of this when you do additional work. Thanks.

[williammartin]

I know that you mostly copied and pasted this from the other function, but it's not really clear to me what this check is actually doing. Under what circumstances would we be interested in this branch?

[JunNishimura]

I think this branch is necessary.

The return value of the interactiveRepoInfo function, opts.Name, is assigned the repository name without the owner name when the user does not belong to any organization.

cli/pkg/cmd/repo/create/create.go

Lines 898 to 906 in fb67da5

	username, orgs, err := userAndOrgs(client, hostname)
	if err != nil {
	return "", "", err
	}
	if len(orgs) == 0 {
	// User doesn't belong to any orgs.
	// Leave the owner blank to indicate a personal repo.
	return name, "", nil
	}

However, the ghrepo.FromFullName function expects Owner/Repo format.

cli/internal/ghrepo/repo.go

Lines 44 to 46 in 3443a75

	// FromFullName extracts the GitHub repository information from the following
	// formats: "OWNER/REPO", "HOST/OWNER/REPO", and a full URL.
	func FromFullName(nwo string) (Interface, error) {

Therefore, in this branch, when the owner name is not included in the opts.Name, the user name is obtained from the userAndOrgs func. And its's passed to ghRepo.FromFullName in the format of UserName/Repo to get ghrepo.Interface.

[williammartin]

Alright. I think this is ok for now, but I'm wondering if we should move this kind of logic into interactiveRepoInfo (or a wrapper around it). It seems like in nearly all cases we want to end up with a name of the form <owner>/<repo>. I'd need to investigate further though.

[JunNishimura]

That sounds a good idea. I tried to move the logic into interactiveRepoInfo, but some of unit tests failed. <owner>/<repo> format might be expected to those cases as well, but fixing those tests was a bit tricky for me, so I didn't change it. If you come up with any solutions, please feel free to implement it!

[JunNishimura]

@williammartin
Thanks for taking time and kind review!

I have left some corrections to code and answers to your questions, so I would appreciate it if you could review it again when you have time!

Thanks

[williammartin]

Almost there I think @JunNishimura

This must be addressed: #7769 (comment) (sorry for misleading you)

I'd like you to remove the conditional here: #7769 (comment) (unless you have a good reason not to)

I think we can hold off on #7769 (comment) (but if you have any thoughts, please add them)

Thanks for your efforts!

[JunNishimura]

@williammartin
Thanks for taking time and reviewing.

I pushed some corrections, so I would appreciate it if you check the PR again!

[williammartin]

This looks good to me, thank you for your work. I'm going to squash-merge this because there's been quite a few commits back and forth.