Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poll permission acceptance endpoint on codespace creation #8179

Merged
merged 2 commits into from Oct 16, 2023

Conversation

dmgardiner25
Copy link
Contributor

@dmgardiner25 dmgardiner25 commented Oct 12, 2023

Related issue: https://github.com/github/codespaces/issues/15018

A new /repos/{owner}/{repo}/codespaces/permissions_check endpoint has been created to allow for clients to poll for acceptance of any devcontainer permissions when creating a codespace rather than making the user go through the create flow again. We poll at an interval of 5 seconds with a 1 minute timeout.

Example of user accepting permissions:
https://github.com/cli/cli/assets/22037769/d343d9ed-b20f-410f-9a9d-dcf6f6ac4686

Example of timeout:
https://github.com/cli/cli/assets/22037769/a97af4a4-8570-494f-9446-d0989332e8d9

@dmgardiner25 dmgardiner25 requested a review from a team as a code owner October 12, 2023 23:59
@cliAutomation cliAutomation added the external pull request originating outside of the CLI core team label Oct 12, 2023
@cliAutomation cliAutomation added this to Needs review 🤔 in The GitHub CLI Oct 12, 2023
@dmgardiner25
Copy link
Contributor Author

Should we make any changes to the non-interactive flow? Polling there seems weird, but is doable.

if !isInteractive {
fmt.Fprintf(a.io.ErrOut, "%s in your browser to review and authorize additional permissions: %s\n", cs.Bold("Open this URL"), allowPermissionsURL)
fmt.Fprintf(a.io.ErrOut, "Alternatively, you can run %q with the %q option to continue without authorizing additional permissions.\n", a.io.ColorScheme().Bold("create"), cs.Bold("--default-permissions"))
return nil, cmdutil.SilentError
}

@dmgardiner25 dmgardiner25 merged commit bc0f63b into cli:trunk Oct 16, 2023
6 checks passed
renovate bot added a commit to scottames/dots that referenced this pull request Oct 24, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [aquaproj/aqua-registry](https://togithub.com/aquaproj/aqua-registry)
| minor | `v4.63.0` -> `v4.73.0` |
|
[bitnami-labs/sealed-secrets](https://togithub.com/bitnami-labs/sealed-secrets)
| patch | `v0.24.1` -> `v0.24.2` |
| [cli/cli](https://togithub.com/cli/cli) | minor | `v2.36.0` ->
`v2.37.0` |
| [golangci/golangci-lint](https://togithub.com/golangci/golangci-lint)
| minor | `v1.54.2` -> `v1.55.0` |
| [homeport/dyff](https://togithub.com/homeport/dyff) | minor | `v1.5.8`
-> `v1.6.0` |
| [junegunn/fzf](https://togithub.com/junegunn/fzf) | minor | `0.42.0`
-> `0.43.0` |
|
[kubernetes-sigs/kustomize](https://togithub.com/kubernetes-sigs/kustomize)
| minor | `v5.1.1` -> `v5.2.1` |
| [kubernetes/kubectl](https://togithub.com/kubernetes/kubectl) | patch
| `1.28.2` -> `1.28.3` |
| [sharkdp/fd](https://togithub.com/sharkdp/fd) | patch | `v8.7.0` ->
`v8.7.1` |
| [weaveworks/eksctl](https://togithub.com/weaveworks/eksctl) | minor |
`v0.161.0` -> `v0.162.0` |

---

### Release Notes

<details>
<summary>aquaproj/aqua-registry (aquaproj/aqua-registry)</summary>

###
[`v4.73.0`](https://togithub.com/aquaproj/aqua-registry/releases/tag/v4.73.0)

[Compare
Source](https://togithub.com/aquaproj/aqua-registry/compare/v4.72.0...v4.73.0)


[Issues](https://togithub.com/aquaproj/aqua-registry/issues?q=is%3Aissue+milestone%3Av4.73.0)
| [Pull
Requests](https://togithub.com/aquaproj/aqua-registry/pulls?q=is%3Apr+milestone%3Av4.73.0)
| aquaproj/aqua-registry@v4.72.0...v4.73.0

#### 🎉 New Packages


[#&#8203;16549](https://togithub.com/aquaproj/aqua-registry/issues/16549)
[ouch-org/ouch](https://togithub.com/ouch-org/ouch): Painless
compression and decompression in the terminal
[@&#8203;CrystalMethod](https://togithub.com/CrystalMethod)

#### Fixes


[#&#8203;16554](https://togithub.com/aquaproj/aqua-registry/issues/16554)
dineshba/tf-summarize: Follow up changes of tf-summarize v0.3.6

Format was changed.

-   https://github.com/dineshba/tf-summarize/releases/tag/v0.3.6
-
[dineshba/tf-summarize#55

> Use tar.gz for linux/darwin and zip for windows

###
[`v4.72.0`](https://togithub.com/aquaproj/aqua-registry/releases/tag/v4.72.0)

[Compare
Source](https://togithub.com/aquaproj/aqua-registry/compare/v4.71.0...v4.72.0)


[Issues](https://togithub.com/aquaproj/aqua-registry/issues?q=is%3Aissue+milestone%3Av4.72.0)
| [Pull
Requests](https://togithub.com/aquaproj/aqua-registry/pulls?q=is%3Apr+milestone%3Av4.72.0)
| aquaproj/aqua-registry@v4.71.0...v4.72.0

#### 🎉 New Packages


[#&#8203;16535](https://togithub.com/aquaproj/aqua-registry/issues/16535)
[redhat-developer/odo](https://togithub.com/redhat-developer/odo): odo -
Developer-focused CLI for fast & iterative container-based application
development on Podman and Kubernetes. Implementation of the open Devfile
standard [@&#8203;monaka](https://togithub.com/monaka)

###
[`v4.71.0`](https://togithub.com/aquaproj/aqua-registry/releases/tag/v4.71.0)

[Compare
Source](https://togithub.com/aquaproj/aqua-registry/compare/v4.70.0...v4.71.0)


[Issues](https://togithub.com/aquaproj/aqua-registry/issues?q=is%3Aissue+milestone%3Av4.71.0)
| [Pull
Requests](https://togithub.com/aquaproj/aqua-registry/pulls?q=is%3Apr+milestone%3Av4.71.0)
| aquaproj/aqua-registry@v4.70.0...v4.71.0

#### 🎉 New Packages


[#&#8203;16498](https://togithub.com/aquaproj/aqua-registry/issues/16498)
[#&#8203;16499](https://togithub.com/aquaproj/aqua-registry/issues/16499)
[michidk/vscli](https://togithub.com/michidk/vscli): A CLI tool to
launch vscode projects, which supports devcontainers

###
[`v4.70.0`](https://togithub.com/aquaproj/aqua-registry/releases/tag/v4.70.0)

[Compare
Source](https://togithub.com/aquaproj/aqua-registry/compare/v4.69.0...v4.70.0)


[Issues](https://togithub.com/aquaproj/aqua-registry/issues?q=is%3Aissue+milestone%3Av4.70.0)
| [Pull
Requests](https://togithub.com/aquaproj/aqua-registry/pulls?q=is%3Apr+milestone%3Av4.70.0)
| aquaproj/aqua-registry@v4.69.0...v4.70.0

#### 🎉 New Packages


[#&#8203;16485](https://togithub.com/aquaproj/aqua-registry/issues/16485)
[#&#8203;16497](https://togithub.com/aquaproj/aqua-registry/issues/16497)
[cloudflare/pint](https://togithub.com/cloudflare/pint): Prometheus rule
linter/validator

[#&#8203;16484](https://togithub.com/aquaproj/aqua-registry/issues/16484)
[#&#8203;16496](https://togithub.com/aquaproj/aqua-registry/issues/16496)
[clowdhaus/eksup](https://togithub.com/clowdhaus/eksup): EKS cluster
upgrade guidance

[#&#8203;16386](https://togithub.com/aquaproj/aqua-registry/issues/16386)
[openclarity/kubeclarity](https://togithub.com/openclarity/kubeclarity):
KubeClarity is a tool for detection and management of Software Bill Of
Materials (SBOM) and vulnerabilities of container images and filesystems
[@&#8203;CrystalMethod](https://togithub.com/CrystalMethod)

[#&#8203;16387](https://togithub.com/aquaproj/aqua-registry/issues/16387)
[openclarity/vmclarity](https://togithub.com/openclarity/vmclarity):
VMClarity is an open source tool for agentless detection and management
of Virtual Machine Software Bill Of Materials (SBOM) and security
threats such as vulnerabilities, exploits, malware, rootkits,
misconfigurations and leaked secrets
[@&#8203;CrystalMethod](https://togithub.com/CrystalMethod)

[#&#8203;16462](https://togithub.com/aquaproj/aqua-registry/issues/16462)
[sxyazi/yazi](https://togithub.com/sxyazi/yazi): Blazing fast terminal
file manager written in Rust, based on async I/O
[@&#8203;CrystalMethod](https://togithub.com/CrystalMethod)

#### Fixes


[#&#8203;16494](https://togithub.com/aquaproj/aqua-registry/issues/16494)
kubernetes-sigs/kustomize: Follow up changes of kustomize v5.2.0 and
v5.2.1

###
[`v4.69.0`](https://togithub.com/aquaproj/aqua-registry/releases/tag/v4.69.0)

[Compare
Source](https://togithub.com/aquaproj/aqua-registry/compare/v4.68.0...v4.69.0)


[Issues](https://togithub.com/aquaproj/aqua-registry/issues?q=is%3Aissue+milestone%3Av4.69.0)
| [Pull
Requests](https://togithub.com/aquaproj/aqua-registry/pulls?q=is%3Apr+milestone%3Av4.69.0)
| aquaproj/aqua-registry@v4.68.0...v4.69.0

#### 🎉 New Packages


[#&#8203;16431](https://togithub.com/aquaproj/aqua-registry/issues/16431)
[biomejs/biome](https://togithub.com/biomejs/biome): A toolchain for web
projects, aimed to provide functionalities to maintain them
[@&#8203;ponkio-o](https://togithub.com/ponkio-o)

[#&#8203;16435](https://togithub.com/aquaproj/aqua-registry/issues/16435)
[ysugimoto/vintage](https://togithub.com/ysugimoto/vintage): VCL
Transpiler for Edge Runtime
[@&#8203;ponkio-o](https://togithub.com/ponkio-o)

###
[`v4.68.0`](https://togithub.com/aquaproj/aqua-registry/releases/tag/v4.68.0)

[Compare
Source](https://togithub.com/aquaproj/aqua-registry/compare/v4.67.0...v4.68.0)


[Issues](https://togithub.com/aquaproj/aqua-registry/issues?q=is%3Aissue+milestone%3Av4.68.0)
| [Pull
Requests](https://togithub.com/aquaproj/aqua-registry/pulls?q=is%3Apr+milestone%3Av4.68.0)
| aquaproj/aqua-registry@v4.67.0...v4.68.0

#### 🎉 New Packages


[#&#8203;16391](https://togithub.com/aquaproj/aqua-registry/issues/16391)
[mfridman/tparse](https://togithub.com/mfridman/tparse): CLI tool for
summarizing go test output. Pipe friendly. CI/CD friendly

[#&#8203;16407](https://togithub.com/aquaproj/aqua-registry/issues/16407)
[mitoma/sver](https://togithub.com/mitoma/sver): Version generator based
on source code

#### Fixes


[#&#8203;16394](https://togithub.com/aquaproj/aqua-registry/issues/16394)
kubeshark/kubeshark: Follow up changes of kubeshark v51.0.0

https://github.com/kubeshark/kubeshark/releases/tag/v51.0.0

> Version tag correlation across docker images, helm chart and CLI
release:
> Choose whether to use the latest release or a past release using a
single version tag (e.g. v51.0.0)

###
[`v4.67.0`](https://togithub.com/aquaproj/aqua-registry/releases/tag/v4.67.0)

[Compare
Source](https://togithub.com/aquaproj/aqua-registry/compare/v4.66.0...v4.67.0)


[Issues](https://togithub.com/aquaproj/aqua-registry/issues?q=is%3Aissue+milestone%3Av4.67.0)
| [Pull
Requests](https://togithub.com/aquaproj/aqua-registry/pulls?q=is%3Apr+milestone%3Av4.67.0)
| aquaproj/aqua-registry@v4.66.0...v4.67.0

#### 🎉 New Packages


[#&#8203;16342](https://togithub.com/aquaproj/aqua-registry/issues/16342)
[sayanarijit/jf](https://togithub.com/sayanarijit/jf): jf %q "JSON
Formatted" [@&#8203;CrystalMethod](https://togithub.com/CrystalMethod)

[#&#8203;16345](https://togithub.com/aquaproj/aqua-registry/issues/16345)
[cloudentity/oauth2c](https://togithub.com/cloudentity/oauth2c):
User-friendly OAuth2 CLI
[@&#8203;CrystalMethod](https://togithub.com/CrystalMethod)

#### Fixes


[#&#8203;16350](https://togithub.com/aquaproj/aqua-registry/issues/16350)
makiuchi-d/arelo: Follow up changes of arelo v1.12.5

-
makiuchi-d/arelo@cf58623
-   https://github.com/makiuchi-d/arelo/releases/tag/v1.12.5


[#&#8203;16353](https://togithub.com/aquaproj/aqua-registry/issues/16353)
jacobdeichert/mask: Follow up changes of mask v0.11.4

Tag format was changed.

-
https://github.com/jacobdeichert/mask/blob/737048d02de20a1f5f1b837ee9a520c001d0cf43/.github/workflows/create-release.yml#L77
-
jacobdeichert/mask@77a3976

TODO: We need to fix aqua-renovate-config too.

-
[aquaproj/aqua-renovate-config#440

###
[`v4.66.0`](https://togithub.com/aquaproj/aqua-registry/releases/tag/v4.66.0)

[Compare
Source](https://togithub.com/aquaproj/aqua-registry/compare/v4.65.0...v4.66.0)


[Issues](https://togithub.com/aquaproj/aqua-registry/issues?q=is%3Aissue+milestone%3Av4.66.0)
| [Pull
Requests](https://togithub.com/aquaproj/aqua-registry/pulls?q=is%3Apr+milestone%3Av4.66.0)
| aquaproj/aqua-registry@v4.65.0...v4.66.0

#### 🎉 New Packages


[#&#8203;16338](https://togithub.com/aquaproj/aqua-registry/issues/16338)
[mesosphere/mindthegap](https://togithub.com/mesosphere/mindthegap):
Easily create and use bundles for air-gapped environments
[@&#8203;CrystalMethod](https://togithub.com/CrystalMethod)

[#&#8203;16330](https://togithub.com/aquaproj/aqua-registry/issues/16330)
[moonrepo/moon](https://togithub.com/moonrepo/moon): A task runner and
repo management tool for the web ecosystem
[@&#8203;CrystalMethod](https://togithub.com/CrystalMethod)

[#&#8203;16335](https://togithub.com/aquaproj/aqua-registry/issues/16335)
[moonrepo/proto](https://togithub.com/moonrepo/proto): A pluggable
multi-language version manager
[@&#8203;CrystalMethod](https://togithub.com/CrystalMethod)

[#&#8203;16337](https://togithub.com/aquaproj/aqua-registry/issues/16337)
[sigi-cli/sigi](https://togithub.com/sigi-cli/sigi): Sigi - a tool for
organizing [@&#8203;booniepepper](https://togithub.com/booniepepper)

[#&#8203;16337](https://togithub.com/aquaproj/aqua-registry/issues/16337)
[so-dang-cool/dt](https://togithub.com/so-dang-cool/dt): dt - duct tape
for your unix pipes
[@&#8203;booniepepper](https://togithub.com/booniepepper)

[#&#8203;16337](https://togithub.com/aquaproj/aqua-registry/issues/16337)
[so-dang-cool/fib](https://togithub.com/so-dang-cool/fib): A Fibonacci
CLI [@&#8203;booniepepper](https://togithub.com/booniepepper)

[#&#8203;16337](https://togithub.com/aquaproj/aqua-registry/issues/16337)
[so-dang-cool/findup](https://togithub.com/so-dang-cool/findup): Find
parent directories
[@&#8203;booniepepper](https://togithub.com/booniepepper)

[#&#8203;16337](https://togithub.com/aquaproj/aqua-registry/issues/16337)
[so-dang-cool/yn](https://togithub.com/so-dang-cool/yn): Dirt-simple
yes/no prompts for your shell scripts
[@&#8203;booniepepper](https://togithub.com/booniepepper)

#### Others


[#&#8203;16332](https://togithub.com/aquaproj/aqua-registry/issues/16332)
misc: update docs link in aqua-policy.yaml
[@&#8203;booniepepper](https://togithub.com/booniepepper)

#### 🎉 New Contributors

Welcome to aqua! Thank you for your contribution!

[@&#8203;booniepepper](https://togithub.com/booniepepper)
[#&#8203;16332](https://togithub.com/aquaproj/aqua-registry/issues/16332)
[#&#8203;16337](https://togithub.com/aquaproj/aqua-registry/issues/16337)

###
[`v4.65.0`](https://togithub.com/aquaproj/aqua-registry/releases/tag/v4.65.0)

[Compare
Source](https://togithub.com/aquaproj/aqua-registry/compare/v4.64.0...v4.65.0)


[Issues](https://togithub.com/aquaproj/aqua-registry/issues?q=is%3Aissue+milestone%3Av4.65.0)
| [Pull
Requests](https://togithub.com/aquaproj/aqua-registry/pulls?q=is%3Apr+milestone%3Av4.65.0)
| aquaproj/aqua-registry@v4.64.0...v4.65.0

#### 🎉 New Packages


[#&#8203;16298](https://togithub.com/aquaproj/aqua-registry/issues/16298)
[#&#8203;16311](https://togithub.com/aquaproj/aqua-registry/issues/16311)
[yonahd/kor](https://togithub.com/yonahd/kor): A Golang Tool to discover
unused Kubernetes Resources

[#&#8203;16308](https://togithub.com/aquaproj/aqua-registry/issues/16308)
[iximiuz/kexp](https://togithub.com/iximiuz/kexp): k'exp - Kubernetes
Explorer

#### Fixes


[#&#8203;16310](https://togithub.com/aquaproj/aqua-registry/issues/16310)
xataio/pgroll: Follow up changes of pgroll v0.3.0

###
[`v4.64.0`](https://togithub.com/aquaproj/aqua-registry/releases/tag/v4.64.0)

[Compare
Source](https://togithub.com/aquaproj/aqua-registry/compare/v4.63.0...v4.64.0)


[Issues](https://togithub.com/aquaproj/aqua-registry/issues?q=is%3Aissue+milestone%3Av4.64.0)
| [Pull
Requests](https://togithub.com/aquaproj/aqua-registry/pulls?q=is%3Apr+milestone%3Av4.64.0)
| aquaproj/aqua-registry@v4.63.0...v4.64.0

#### 🎉 New Packages


[#&#8203;16291](https://togithub.com/aquaproj/aqua-registry/issues/16291)
[googleapis/api-linter](https://togithub.com/googleapis/api-linter): A
linter for APIs defined in protocol buffers
[@&#8203;yanolab](https://togithub.com/yanolab)

[#&#8203;16244](https://togithub.com/aquaproj/aqua-registry/issues/16244)
[makew0rld/didder](https://togithub.com/makew0rld/didder): An extensive,
fast, and accurate command-line image dithering tool

</details>

<details>
<summary>bitnami-labs/sealed-secrets
(bitnami-labs/sealed-secrets)</summary>

###
[`v0.24.2`](https://togithub.com/bitnami-labs/sealed-secrets/blob/HEAD/RELEASE-NOTES.md#v0242)

[Compare
Source](https://togithub.com/bitnami-labs/sealed-secrets/compare/v0.24.1...v0.24.2)

##### Changelog

- Fix issue where sealed secrets status is not updated if sealed secret…
([#&#8203;1295](https://togithub.com/bitnami-labs/sealed-secrets/pull/1295))
- Bump golang.org/x/crypto from 0.13.0 to
0.14.0([#&#8203;1341](https://togithub.com/bitnami-labs/sealed-secrets/pull/1341))
- Bump github.com/onsi/ginkgo/v2 from 2.12.1 to 2.13.0
([#&#8203;1342](https://togithub.com/bitnami-labs/sealed-secrets/pull/1342))
- Bump golang.org/x/net from 0.14.0 to 0.17.0
([#&#8203;1344](https://togithub.com/bitnami-labs/sealed-secrets/pull/1344))

</details>

<details>
<summary>cli/cli (cli/cli)</summary>

### [`v2.37.0`](https://togithub.com/cli/cli/releases/tag/v2.37.0):
GitHub CLI 2.37.0

[Compare Source](https://togithub.com/cli/cli/compare/v2.36.0...v2.37.0)

#### ⚠️ ⚠️ Breaking Changes ⚠️ ⚠️

- `project`: Remove `template` field from `--format=json` output by
[@&#8203;samcoe](https://togithub.com/samcoe) in
[cli/cli#8160
- In v2.34.0 we introduced the `template` field when outputing projects
to JSON, unfortunately
we forgot to take into account our GHES users. This field does not exist
on GHES 3.8 and older.
Including this field in our queries and output broke nearly all the
`project` commands for users
targeting these older versions of GHES. As we try our hardest to keep
`gh` compatible with all
non-deprecated GHES versions this was a pretty big mistake. In order to
fix it we are reverting
the querying and exporting of the `template` field for `project`
commands. We apologize for the
inconvenience this may cause, and plan to bring back this field once
GHES 3.8 gets deprecated.

#### What's Changed

- `repo create`: Allow `--disable-issues` and `--template` flags to be
used together by [@&#8203;utouto97](https://togithub.com/utouto97) in
[cli/cli#7918
- `repo create`: Allow `--homepage` and `--template` flag to be used
together by [@&#8203;arunsathiya](https://togithub.com/arunsathiya) in
[cli/cli#8188
- `repo create`: Allow creating repositories from templates in
interactive mode by
[@&#8203;JunNishimura](https://togithub.com/JunNishimura) in
[cli/cli#7769
- `repo fork`: Set default repo when forking repo by
[@&#8203;kbailey4444](https://togithub.com/kbailey4444) in
[cli/cli#7768
- `codespace`: Migrate all Codespaces operations from Live Share to Dev
Tunnels by [@&#8203;dmgardiner25](https://togithub.com/dmgardiner25) in
[cli/cli#8149
- `codespace create`: Poll permission acceptance endpoint on codespace
creation by [@&#8203;dmgardiner25](https://togithub.com/dmgardiner25) in
[cli/cli#8179
- `pr create`: Remove duplicates targets for push survey by
[@&#8203;benebsiny](https://togithub.com/benebsiny) in
[cli/cli#8184
- `pr create`: Fix typo in documentation by
[@&#8203;darthwalsh](https://togithub.com/darthwalsh) in
[cli/cli#8115
- `browse`: Do not use relative paths when `--repo` flag is used by
[@&#8203;benebsiny](https://togithub.com/benebsiny) in
[cli/cli#8141

#### Other Changes

- Add homebrew-bump-debug workflow by
[@&#8203;williammartin](https://togithub.com/williammartin) in
[cli/cli#8114
- Update deployment.yml by
[@&#8203;andyfeller](https://togithub.com/andyfeller) in
[cli/cli#8116
- `dependencies`: Update to fix security vulnerability by
[@&#8203;samcoe](https://togithub.com/samcoe) in
[cli/cli#8176
- `dependencies`: bump github.com/gabriel-vasile/mimetype from 1.4.2 to
1.4.3 by [@&#8203;dependabot](https://togithub.com/dependabot) in
[cli/cli#8185

#### New Contributors

- [@&#8203;darthwalsh](https://togithub.com/darthwalsh) made their first
contribution in
[cli/cli#8115
- [@&#8203;benebsiny](https://togithub.com/benebsiny) made their first
contribution in
[cli/cli#8184

**Full Changelog**: cli/cli@v2.36.0...v2.37.0

</details>

<details>
<summary>golangci/golangci-lint (golangci/golangci-lint)</summary>

###
[`v1.55.0`](https://togithub.com/golangci/golangci-lint/blob/HEAD/CHANGELOG.md#v1550)

[Compare
Source](https://togithub.com/golangci/golangci-lint/compare/v1.54.2...v1.55.0)

1.  new linters
    -   `gochecksumtype`: https://github.com/alecthomas/go-check-sumtype
    -   `inamedparam`: https://github.com/macabu/inamedparam
    -   `perfsprint`: https://github.com/catenacyber/perfsprint
    -   `protogetter`: https://github.com/ghostiam/protogetter
    -   `sloglint`: https://github.com/go-simpler/sloglint
    -   `testifylint`: https://github.com/Antonboom/testifylint
2.  updated linters
    -   `bidichk`: from 0.2.4 to 0.2.7
    -   `decorder`: from 0.4.0 to 0.4.1
    -   `dupword`: from 0.0.12 to 0.0.13
    -   `errchkjson`: from 0.3.1 to 0.3.6
    -   `gci`: from 0.11.0 to 0.11.2
    -   `ginkgolinter`: from 0.13.5 to 0.14.0
    -   `go-errorlint`: from 1.4.4 to 1.4.5
    -   `gocognit`: from 1.0.7 to 1.1.0
    -   `goconst`: from 1.5.1 to 1.6.0
    -   `godot`: from 1.4.14 to 1.4.15
    -   `gofmt`: update to HEAD
    -   `goimports`: update to HEAD
    -   `gosec`: from 2.17.0 to 2.18.1
    -   `gosmopolitan`: from 1.2.1 to 1.2.2
    -   `govet`: add `appends` analyzer
    -   `ireturn`: from 0.2.0 to 0.2.1
    -   `protogetter`: from 0.2.2 to 0.2.3
- `revgrep`: from
[`745bb2f`](https://togithub.com/golangci/golangci-lint/commit/745bb2f7c2e6)
to v0.5.0
    -   `revive`: from 1.3.2 to 1.3.4
    -   `sqlclosecheck`: from 0.4.0 to 0.5.1
    -   `staticcheck`: from 0.4.5 to 0.4.6
    -   `tagalign`: from 1.3.2 to 1.3.3
    -   `unused`: support passing in options
3.  misc.
    -   Add a pre-commit hook to check all files
4.  Documentation
    -   add source options to exclude-rules docs
- `gosec`: add G602 to includes/excludes inside .golangci.reference.yml

</details>

<details>
<summary>homeport/dyff (homeport/dyff)</summary>

### [`v1.6.0`](https://togithub.com/homeport/dyff/releases/tag/v1.6.0):
dyff release v1.6.0

[Compare
Source](https://togithub.com/homeport/dyff/compare/v1.5.8...v1.6.0)

#### Note

There is a noticeable change in the path output for list entries that
are Kubernetes items. Instead of `metadata.name=name`, it will now show
`resource=apiVersion/kind/name`.

#### Changelog

- [`bdf15b9`](https://togithub.com/homeport/dyff/commit/bdf15b9) Add
test case where from or to is null
- [`1c52e49`](https://togithub.com/homeport/dyff/commit/1c52e49) Add
test case to check new if branch
- [`d74f059`](https://togithub.com/homeport/dyff/commit/d74f059)
Introduce identifier interface
- [`8ff464a`](https://togithub.com/homeport/dyff/commit/8ff464a) Provide
Kubernetes lists example
- [`3ee83a7`](https://togithub.com/homeport/dyff/commit/3ee83a7)
Refactor core code by sorting functions
- [`ff19a8d`](https://togithub.com/homeport/dyff/commit/ff19a8d)
Refactor core code
- [`581505c`](https://togithub.com/homeport/dyff/commit/581505c) Use
`assets` function in test cases
- [`61cba04`](https://togithub.com/homeport/dyff/commit/61cba04) Add
`apiVersion` to Kubernetes look-up
- [`e196bb1`](https://togithub.com/homeport/dyff/commit/e196bb1) Move
Kubernetes assests into subdirectories
- [`2d431d4`](https://togithub.com/homeport/dyff/commit/2d431d4) Merge
pull request
[#&#8203;322](https://togithub.com/homeport/dyff/issues/322) from
homeport/dependabot/go_modules/golang.org/x/net-0.17.0
- [`e5585da`](https://togithub.com/homeport/dyff/commit/e5585da) Bump
golang.org/x/net from 0.16.0 to 0.17.0
- [`f1cda91`](https://togithub.com/homeport/dyff/commit/f1cda91) Merge
pull request
[#&#8203;321](https://togithub.com/homeport/dyff/issues/321) from
homeport/dependabot/go_modules/main/github.com/onsi/ginkgo/v2-2.13.0
- [`e2d462a`](https://togithub.com/homeport/dyff/commit/e2d462a) Bump
github.com/onsi/ginkgo/v2 from 2.12.1 to 2.13.0
- [`50a46ce`](https://togithub.com/homeport/dyff/commit/50a46ce) Tidy up
test setup
- [`629e941`](https://togithub.com/homeport/dyff/commit/629e941) Merge
pull request
[#&#8203;320](https://togithub.com/homeport/dyff/issues/320) from
homeport/dependabot/go_modules/main/github.com/onsi/gomega-1.28.0
- [`b01ecb9`](https://togithub.com/homeport/dyff/commit/b01ecb9) Bump
github.com/onsi/gomega from 1.27.10 to 1.28.0
- [`3988187`](https://togithub.com/homeport/dyff/commit/3988187) Merge
pull request
[#&#8203;318](https://togithub.com/homeport/dyff/issues/318) from
homeport/dependabot/go_modules/main/github.com/onsi/ginkgo/v2-2.12.1
- [`ffe44d9`](https://togithub.com/homeport/dyff/commit/ffe44d9) Bump
github.com/onsi/ginkgo/v2 from 2.12.0 to 2.12.1
- [`221a1e6`](https://togithub.com/homeport/dyff/commit/221a1e6) Update
Go version in README
- [`2a8b1e8`](https://togithub.com/homeport/dyff/commit/2a8b1e8) Bump Go
version to `1.20`
- [`93a18e5`](https://togithub.com/homeport/dyff/commit/93a18e5) Merge
pull request
[#&#8203;314](https://togithub.com/homeport/dyff/issues/314) from
homeport/dependabot/go_modules/main/github.com/onsi/ginkgo/v2-2.12.0
- [`450031b`](https://togithub.com/homeport/dyff/commit/450031b) Bump
github.com/onsi/ginkgo/v2 from 2.11.0 to 2.12.0
- [`a840ba7`](https://togithub.com/homeport/dyff/commit/a840ba7) Merge
pull request
[#&#8203;313](https://togithub.com/homeport/dyff/issues/313) from
homeport/dependabot/go_modules/main/github.com/onsi/gomega-1.27.10
- [`a4fdad5`](https://togithub.com/homeport/dyff/commit/a4fdad5) Bump
github.com/onsi/gomega from 1.27.8 to 1.27.10

#### What's Changed

- Bump github.com/onsi/gomega from 1.27.8 to 1.27.10 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[homeport/dyff#313
- Bump github.com/onsi/ginkgo/v2 from 2.11.0 to 2.12.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[homeport/dyff#314
- Bump Go version to `1.20` by
[@&#8203;HeavyWombat](https://togithub.com/HeavyWombat) in
[homeport/dyff#315
- Bump github.com/onsi/ginkgo/v2 from 2.12.0 to 2.12.1 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[homeport/dyff#318
- Bump github.com/onsi/gomega from 1.27.10 to 1.28.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[homeport/dyff#320
- Bump github.com/onsi/ginkgo/v2 from 2.12.1 to 2.13.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[homeport/dyff#321
- Bump golang.org/x/net from 0.16.0 to 0.17.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[homeport/dyff#322
- Support `apiVersion` and `kind` in lists of Kubernetes items by
[@&#8203;HeavyWombat](https://togithub.com/HeavyWombat) in
[homeport/dyff#323

**Full Changelog**:
homeport/dyff@v1.5.8...v1.6.0

</details>

<details>
<summary>junegunn/fzf (junegunn/fzf)</summary>

###
[`v0.43.0`](https://togithub.com/junegunn/fzf/blob/HEAD/CHANGELOG.md#0430)

[Compare
Source](https://togithub.com/junegunn/fzf/compare/0.42.0...0.43.0)

- (Experimental) Added support for Kitty image protocol in the preview
window
    ```sh
    fzf --preview='
      if file --mime-type {} | grep -qF image/; then
    ```

### --transfer-mode=memory is the fastest option but if you want fzf to
be able

### to redraw the image on terminal resize or on
'change-preview-window',

### you need to use --transfer-mode=stream.

kitty icat --clear --transfer-mode=memory --stdin=no
--place=${FZF_PREVIEW_COLUMNS}x${FZF_PREVIEW_LINES}@&#8203;0x0 {} | sed
\$d
    else
      bat --color=always {}
    fi

'

- (Experimental) `--listen` server can report program state in JSON
format (`GET /`)
    ```sh

</details>

<details>
<summary>kubernetes-sigs/kustomize (kubernetes-sigs/kustomize)</summary>

###
[`v5.2.1`](https://togithub.com/kubernetes-sigs/kustomize/releases/tag/kustomize/v5.2.1)

[Compare
Source](https://togithub.com/kubernetes-sigs/kustomize/compare/kustomize/v5.2.0...kustomize/v5.2.1)

This is a patch of kustomize v5.2.0 and should fix the directory
formatting issues in its assets.

##### Release notes from v5.2.0 (Delta from v5.1.1)

Currently, Kustomize has already resolved that block on releasing for
Windows and Darwin
ARM([kubernetes-sigs/kustomize#5220).
Now, We can release those architecture binaries.

##### New Features for `kustomize build`

- `patches` accept a patch file with multiple
patches([#&#8203;5194](https://togithub.com/kubernetes-sigs/kustomize/issues/5194))
- Add support for OCI based helm
repos([#&#8203;5167](https://togithub.com/kubernetes-sigs/kustomize/issues/5167))

##### New Features for `kustomize edit` subcommands


[#&#8203;4486](https://togithub.com/kubernetes-sigs/kustomize/issues/4486):
add: "edit add labels" command adds an option for labels without
selector

[#&#8203;5327](https://togithub.com/kubernetes-sigs/kustomize/issues/5327):
feat: add remove configmap command

[#&#8203;5333](https://togithub.com/kubernetes-sigs/kustomize/issues/5333):
Add --no-verify flag to edit add resource command

[#&#8203;5344](https://togithub.com/kubernetes-sigs/kustomize/issues/5344):
feat: add remove secret command

[#&#8203;5367](https://togithub.com/kubernetes-sigs/kustomize/issues/5367):
fix: add namespace option to 'edit add configmap' command

##### Bug fixes


[#&#8203;5342](https://togithub.com/kubernetes-sigs/kustomize/issues/5342):
Update imdario/mergo to v0.3.13

[#&#8203;5196](https://togithub.com/kubernetes-sigs/kustomize/issues/5196):
fix: patch additions honor source key style

##### chore


[#&#8203;5345](https://togithub.com/kubernetes-sigs/kustomize/issues/5345):
docs: update remove configmap comment

[#&#8203;5193](https://togithub.com/kubernetes-sigs/kustomize/issues/5193):
\[refactor]: Internalize loader api

[#&#8203;5315](https://togithub.com/kubernetes-sigs/kustomize/issues/5315):
refactor: change "add configmap/secret" commands to reuse code and
improve tests

##### Dependency updates


[#&#8203;5254](https://togithub.com/kubernetes-sigs/kustomize/issues/5254):
release cleanup

[#&#8203;5197](https://togithub.com/kubernetes-sigs/kustomize/issues/5197):
Switch to json-patch v5

[#&#8203;5393](https://togithub.com/kubernetes-sigs/kustomize/issues/5393):
Update kyaml to v0.15.0

[#&#8203;5394](https://togithub.com/kubernetes-sigs/kustomize/issues/5394):
Update cmd/config to v0.12.0

[#&#8203;5395](https://togithub.com/kubernetes-sigs/kustomize/issues/5395):
Update api to v0.15.0

###
[`v5.2.0`](https://togithub.com/kubernetes-sigs/kustomize/releases/tag/kustomize/v5.2.0)

[Compare
Source](https://togithub.com/kubernetes-sigs/kustomize/compare/kustomize/v5.1.1...kustomize/v5.2.0)

##### Known issue: The directory format of the kustomize binary asset
has unintentionally changed. We have fixed this in kustomize v5.2.1.
Users who depend on the directory structure or use the
install_kustomize.sh script should skip this release.

Currently, Kustomize has already resolved that block on releasing for
Windows and Darwin
ARM([kubernetes-sigs/kustomize#5220).
Now, We can release those architecture binaries.

##### New Feature

- `patches` accept a patch file with multiple
patches([#&#8203;5194](https://togithub.com/kubernetes-sigs/kustomize/issues/5194))
- Add support for OCI based helm
repos([#&#8203;5167](https://togithub.com/kubernetes-sigs/kustomize/issues/5167))

##### New Feature for `kustomize edit` subcommands


[#&#8203;4486](https://togithub.com/kubernetes-sigs/kustomize/issues/4486):
add: "edit add labels" command adds an option for labels without
selector

[#&#8203;5327](https://togithub.com/kubernetes-sigs/kustomize/issues/5327):
feat: add remove configmap command

[#&#8203;5333](https://togithub.com/kubernetes-sigs/kustomize/issues/5333):
Add --no-verify flag to edit add resource command

[#&#8203;5344](https://togithub.com/kubernetes-sigs/kustomize/issues/5344):
feat: add remove secret command

[#&#8203;5367](https://togithub.com/kubernetes-sigs/kustomize/issues/5367):
fix: add namespace option to 'edit add configmap' command

##### Bug fixes


[#&#8203;5342](https://togithub.com/kubernetes-sigs/kustomize/issues/5342):
Update imdario/mergo to v0.3.13

[#&#8203;5196](https://togithub.com/kubernetes-sigs/kustomize/issues/5196):
fix: patch additions honor source key style

##### chore


[#&#8203;5345](https://togithub.com/kubernetes-sigs/kustomize/issues/5345):
docs: update remove configmap comment

[#&#8203;5193](https://togithub.com/kubernetes-sigs/kustomize/issues/5193):
\[refactor]: Internalize loader api

[#&#8203;5315](https://togithub.com/kubernetes-sigs/kustomize/issues/5315):
refactor: change "add configmap/secret" commands to reuse code and
improve tests

##### Dependency updates


[#&#8203;5254](https://togithub.com/kubernetes-sigs/kustomize/issues/5254):
release cleanup

[#&#8203;5197](https://togithub.com/kubernetes-sigs/kustomize/issues/5197):
Switch to json-patch v5

[#&#8203;5393](https://togithub.com/kubernetes-sigs/kustomize/issues/5393):
Update kyaml to v0.15.0

[#&#8203;5394](https://togithub.com/kubernetes-sigs/kustomize/issues/5394):
Update cmd/config to v0.12.0

[#&#8203;5395](https://togithub.com/kubernetes-sigs/kustomize/issues/5395):
Update api to v0.15.0

</details>

<details>
<summary>kubernetes/kubectl (kubernetes/kubectl)</summary>

###
[`v1.28.3`](https://togithub.com/kubernetes/kubectl/compare/kubernetes-1.28.2...kubernetes-1.28.3)

[Compare
Source](https://togithub.com/kubernetes/kubectl/compare/kubernetes-1.28.2...kubernetes-1.28.3)

</details>

<details>
<summary>sharkdp/fd (sharkdp/fd)</summary>

###
[`v8.7.1`](https://togithub.com/sharkdp/fd/blob/HEAD/CHANGELOG.md#v871)

[Compare
Source](https://togithub.com/sharkdp/fd/compare/v8.7.0...v8.7.1)

#### Bugfixes

-   `-1` properly conflicts with the exec family of options.
-   `--max-results` overrides `-1`
- `--quiet` properly conflicts with the exec family of options. This
used to be the case, but broke during the switch to clap-derive
- `--changed-within` now accepts a space as well as a "T" as the
separator between date and time (due to update of chrono dependency)

#### Other

-   Many dependencies were updated
-   Some documentation was updated and fixed

</details>

<details>
<summary>weaveworks/eksctl (weaveworks/eksctl)</summary>

###
[`v0.162.0`](https://togithub.com/eksctl-io/eksctl/releases/tag/v0.162.0):
eksctl 0.162.0 (permalink)

[Compare
Source](https://togithub.com/weaveworks/eksctl/compare/0.161.0...0.162.0)

### Release v0.162.0

#### 🎯 Improvements

- Set AWS credential expiry window to 30 minutes
([#&#8203;7116](https://togithub.com/weaveworks/eksctl/issues/7116))

#### 🐛 Bug Fixes

- Fix ELB cleanup failure due to resource name ending with a hyphen
([#&#8203;7029](https://togithub.com/weaveworks/eksctl/issues/7029))
- Fix coredns 1.28 asset
([#&#8203;7126](https://togithub.com/weaveworks/eksctl/issues/7126))

#### Acknowledgments

Weaveworks would like to sincerely thank:
[@&#8203;0xlen](https://togithub.com/0xlen) and
[@&#8203;otterley](https://togithub.com/otterley)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 4pm on thursday" in timezone
America/Los_Angeles, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/scottames/dots).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xOS4yIiwidXBkYXRlZEluVmVyIjoiMzcuMzEuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
suna1992 referenced this pull request in github/docs Oct 30, 2023
Updated to correct team cc mention
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external pull request originating outside of the CLI core team
Projects
No open projects
The GitHub CLI
  
Needs review 🤔
Development

Successfully merging this pull request may close these issues.

None yet

4 participants