Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Number and URL included in scriptable output #1580

Merged
merged 2 commits into from
Aug 26, 2020
Merged

Number and URL included in scriptable output #1580

merged 2 commits into from
Aug 26, 2020

Conversation

dan1elhughes
Copy link
Contributor

@dan1elhughes dan1elhughes commented Aug 26, 2020 •
edited

Adds the PR number and the PR URL in the output provided to non-TTY outputs.

Closes #1532

Example on this PR 
title:	Number and URL included in scriptable output
state:	OPEN
author:	dan1elhughes
labels:	
assignees:	
reviewers:	
projects:	
milestone:	
number:	1580
url:	https://github.com/cli/cli/pull/1580
--
Adds the PR number and the PR URL in the output provided to non-TTY outputs.

Closes #1532

mislav
mislav approved these changes Aug 26, 2020
View reviewed changes
Copy link
Contributor

@mislav mislav left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! This looks good to me; thank you!

@vilmibm vilmibm merged commit f1ea794 into cli:trunk Aug 26, 2020
@dan1elhughes dan1elhughes deleted the feature/number-url-scriptable-output branch August 27, 2020 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mislav mislav mislav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide all metadata fields in scripted pr view
3 participants
@dan1elhughes @mislav @vilmibm