-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document that reviewers can be teams #2465
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! 🎉
Co-authored-by: Mislav Marohnić <hi@mislav.net>
@mislav thanks for the quick response! I addressed all your comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great! Thank you 🙇
This comment has been minimized.
This comment has been minimized.
I don't see any updates on gh pr create yet - does this need to get deployed to production? |
@MaxHorstmann The documentation site will be automatically re-generated with the next release. We don't re-generate the site from |
Thanks for the clarification!
…On Tue, Dec 1, 2020, 6:49 AM Mislav Marohnić ***@***.***> wrote:
@MaxHorstmann <https://github.com/MaxHorstmann> The documentation site
will be automatically re-generated with the next release.
We don't re-generate the site from trunk between releases because we want
to avoid accidentally publishing docs for un-released features.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2465 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACSEP6OPAWPNMR6CQM2JE3SSTJ5VANCNFSM4UACTZ2A>
.
|
Co-authored-by: Mislav Marohnić <mislav@github.com>
Took me a while to figure out that when creating a PR via gh pr create, reviewers
and assigneescan be both individual users and also entire teams (confirmed in source).This is a little different from the equivalent API endpoint, which has separate parameters
reviewers
andteam_reviewers
.PR just seeks to document this a little better.
Releated Stack Overflow question