Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pr create --body-file flag #3018

Merged
merged 2 commits into from
Mar 2, 2021
Merged

Add pr create --body-file flag #3018

merged 2 commits into from
Mar 2, 2021

Conversation

castaneai
Copy link
Contributor

The --body-file flag helps to create long bodies or multi-line bodies.
In particular, it avoids the "filename or extension is too long" problem in Windows environments.

I refer to the following comments.
#595 (comment)

Copy link
Contributor

@mislav mislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is great!

I've also added issue create -F for parity and converted the tests to a more focused style of tests that exercises only flag parsing in isolation.

@mislav mislav merged commit 3444d00 into cli:trunk Mar 2, 2021
@StanleyGoldman
Copy link

StanleyGoldman commented Mar 9, 2021

@castaneai @mislav This is awesome! I would ❤️ if you ported it to the gh issue edit command.

@castaneai castaneai deleted the pr-create-body-file branch March 9, 2021 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants