Adds the ability to list environment secrets - gh secret list -e dev #3270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is just adding to the list command, we should probably also consider adding environment secret handling to the other gh secret commands. |
goo952
approved these changes
Mar 23, 2021
goo952
approved these changes
Mar 23, 2021
goo952
approved these changes
Mar 23, 2021
goo952
approved these changes
Mar 23, 2021
goo952
approved these changes
Mar 23, 2021
goo952
approved these changes
Mar 23, 2021
goo952
approved these changes
Mar 23, 2021
mislav
suggested changes
Mar 23, 2021
curtcurt871
reviewed
Mar 25, 2021
|
Ignore for now, I need to fix the unit tests |
|
This should be ready for review again. Sorry it took so long, life happens... |
|
@mislav Is there anything else you would like changed to get this wrapped up? |
Co-authored-by: Mislav Marohnić <mislav@github.com>
mislav
force-pushed
the
feature/issue-3265-implement-gh-secret-list-env
branch
from
1dea319
to
e5bdaaa
Compare
mislav
approved these changes
May 31, 2021
There was a problem hiding this comment.
Thanks for the updates, and sorry for the late reply. The changeset looked good, but the bit with fetching the repository ID was over-complicated. The API allows us to query environment secrets without knowing the numeric repo ID. I've pushed a simplification.
|
@mislav Thanks a ton! Glad to contribute and get this pushed through. |
This was referenced Jun 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First time contributor here, so excuse me if I missed anything in the guidelines.
This fixes #3265
Environment Secrets are not included in gh secret list. This adds a new flag to gh secret list called env (-e) which takes in a string that correlates with your environment secrets name. The output is the same as gh secret list, but it only includes the environment secrets.
Here is the command and the output:
This is just a draft because I'm sure I'm missing things and I would lo have some guidance.