Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for removing environment secrets #3774

Merged
merged 1 commit into from
Jun 3, 2021

Conversation

browniebroke
Copy link
Contributor

Building on top of #3270 (list env secrets) and #3769 (set env secrets), this adds support for removing environment secrets.

Fixes #3265

@cliAutomation cliAutomation added this to Needs review 🤔 in The GitHub CLI Jun 3, 2021
Copy link
Contributor

@mislav mislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great; thank you!

The GitHub CLI automation moved this from Needs review 🤔 to Needs to be merged 🎉 Jun 3, 2021
@mislav mislav merged commit b166376 into cli:trunk Jun 3, 2021
The GitHub CLI automation moved this from Needs to be merged 🎉 to Pending Release 🥚 Jun 3, 2021
@browniebroke browniebroke deleted the feat/remove-env-secret branch June 3, 2021 14:25
@github-actions github-actions bot moved this from Pending Release 🥚 to Done 💤 in The GitHub CLI Jun 3, 2021
Copy link

@natasha1007 natasha1007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pkg/cmd/secret/remove/remove_test.go


err := removeRun(opts)
assert.NoError(t, err)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

n

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
The GitHub CLI
  
Done 💤
Development

Successfully merging this pull request may close these issues.

Add support for environment secrets
3 participants