Dont follow redirects on repo delete #7106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mislav
suggested changes
Mar 8, 2023
vilmibm
approved these changes
Mar 9, 2023
mislav
suggested changes
Mar 9, 2023
There was a problem hiding this comment.
This will work to prevent a redirected repo from getting deleted, but the error message as surfaced to the user will be confusing:
HTTP 301: Moved Permanently
Based on this alone, I don't think the user will know what they did wrong. I think a better error message would print the new full name of the repo and ask the user, if they are still sure they want to delete it, to specify the new name.
samcoe
commented
Mar 12, 2023
| statusCode == http.StatusTemporaryRedirect || | ||
| statusCode == http.StatusPermanentRedirect { | ||
| cs := opts.IO.ColorScheme() | ||
| fmt.Fprintf(opts.IO.ErrOut, "%s Failed to delete repository: %s has changed name or transfered ownership\n", cs.FailureIcon(), fullName) |
There was a problem hiding this comment.
Went with this error message as the redirect response from the server does not give the new repository name just an ID.
This was referenced Sep 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't follow redirects when trying to do repo deletion. This prevents accidentally deleting repos that have transferred ownership.