Support sub-packages having arch=('all') v3
#262
Conversation
|
I have added the changes you requested (I think). I created a new PR because my other PR as associated to a fork from Jabir-Srj/makedeb, for whatever reason. |
|
Hey I'm back, terribly sorry for the wait! Some other projects I'm working on have been taking up a ton of my time, and I'm just now getting back to being able to work on makedeb a bit. That I'll go ahead and get your PR reviewed real quick :) |
There was a problem hiding this comment.
It would probably be good to make a test that makes sure that if a global arch=('all') is set, that arch=('amd64') or anything inside of a package_* function fails.
I can get this done myself before a merge if need be, I'm just making a note of it here so I know it needs to get done.
There was a problem hiding this comment.
Or should that be desired behavior? I hadn't really thought about subpackages straight-up having different architectures like i386 and stuff like that. What do you think?
There was a problem hiding this comment.
Or should that be desired behavior? I hadn't really thought about subpackages straight-up having different architectures like
i386and stuff like that. What do you think?
I don't think that sub-packages should have arbitrary architectures.
To me the only use case that make sense is a top-level arch=(amd64|i386|...) and sub-packages that are arch independent, for documentation and/or assets files.
There was a problem hiding this comment.
It would probably be good to make a test that makes sure that if a global
arch=('all')is set, thatarch=('amd64')or anything inside of apackage_*function fails.I can get this done myself before a merge if need be, I'm just making a note of it here so I know it needs to get done.
I am not sure how to go about checking this.
There was a problem hiding this comment.
I think it'd be good to stop sub-packages from having specific architecture too, it can always be expanded in the future if need be as well.
I am not sure how to go about checking this.
You can see if the ${INFAKEROOT} variable is set, makedeb sets that when things like package() are being ran (see alpha:src/main.sh#L1340 for an example of the syntax that's used across the codebase).
There was a problem hiding this comment.
I has thinking if this could be done at linting time, any pointers on how to do this ?
This patch allows sub-packages to override the arch attribute setting it to `all`. The use case for this feature is when generating documentation packages that can be installed in any architecture.
bithium
force-pushed
the
feature/support_all_arch_for_subpackages
branch
from
b9a1470
to
c2dffa6
Compare
This patch allows sub-packages to override the arch attribute setting it to
all.The use case for this feature is when generating documentation packages that can be installed in any architecture.