Use SmartBaseRepoFunc for api command #7594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The placeholder `{repo}` was previously substituted with whichever
remote happened to be sorted first via `sort.Sort()`. Instead:
- if `$GH_REPO` is not set, use `SmartBaseRepoFunc` to select the
remote the user has configured via `repo set-default`.
- if `$GH_REPO` is set, use `OverrideBaseRepoFunc` as before.
cliAutomation
added
the
external
|
Hi! Thanks for the pull request. Please ensure that this change is linked to an issue by mentioning an issue number in the description of the pull request. If this pull request would close the issue, please put the word 'Fixes' before the issue number somewhere in the pull request body. If this is a tiny change like fixing a typo, feel free to ignore this message. |
samcoe
approved these changes
Jul 6, 2023
There was a problem hiding this comment.
@whi-tw Thanks for the contribution! I pushed one small commit to undo the changes around OverrideBaseRepoFunc as they were not necessary for this feature. OverrideBaseRepoFunc already properly handles GH_REPO environment variable being set.
@samcoe I think you may be wrong here, but I can’t be certain until I’m in front of a computer. If I remember correctly, without this change to PreRun, the change in root.go is irrelevant as the baserepofunc is always overridden. The check of the envar is necessary, so we only use OverrideBaseRepoFunc if it’s set |
|
@whi-tw I did test out that the new feature worked with |
Okay, so, perhaps I should have waited until I actually looked at the code again before replying! That does seem to be the case now - I'm not sure exactly what I was doing before to test this, as I definitely saw the opposite when testing, but It's now working? I probably made assumptions about what TL;DR: we good, I'm bad at mornings |
renovate bot
added a commit
to scottames/dots
that referenced
this pull request
Jul 12, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [aquaproj/aqua-registry](https://togithub.com/aquaproj/aqua-registry) | minor | `v4.25.0` -> `v4.26.0` | | [cli/cli](https://togithub.com/cli/cli) | minor | `v2.31.0` -> `v2.32.0` | | [fluxcd/flux2](https://togithub.com/fluxcd/flux2) | patch | `v2.0.0` -> `v2.0.1` | --- ### Release Notes <details> <summary>aquaproj/aqua-registry (aquaproj/aqua-registry)</summary> ### [`v4.26.0`](https://togithub.com/aquaproj/aqua-registry/releases/tag/v4.26.0) [Compare Source](https://togithub.com/aquaproj/aqua-registry/compare/v4.25.0...v4.26.0) [Issues](https://togithub.com/aquaproj/aqua-registry/issues?q=is%3Aissue+milestone%3Av4.26.0) | [Pull Requests](https://togithub.com/aquaproj/aqua-registry/pulls?q=is%3Apr+milestone%3Av4.26.0) | aquaproj/aqua-registry@v4.25.0...v4.26.0 #### 🎉 New Packages [#​13656](https://togithub.com/aquaproj/aqua-registry/issues/13656) [cilium/cilium-cli](https://togithub.com/cilium/cilium-cli): CLI to install, manage & troubleshoot Kubernetes clusters running Cilium [@​honahuku](https://togithub.com/honahuku) [#​13657](https://togithub.com/aquaproj/aqua-registry/issues/13657) [ponkio-o/ec2x](https://togithub.com/ponkio-o/ec2x): A cli tool of connect to ec2 instance [@​ponkio-o](https://togithub.com/ponkio-o) #### 🎉 New Contributor [@​honahuku](https://togithub.com/honahuku) [#​13656](https://togithub.com/aquaproj/aqua-registry/issues/13656) </details> <details> <summary>cli/cli (cli/cli)</summary> ### [`v2.32.0`](https://togithub.com/cli/cli/releases/tag/v2.32.0): GitHub CLI 2.32.0 [Compare Source](https://togithub.com/cli/cli/compare/v2.31.0...v2.32.0) hello terminal fans, it's me [@​vilmibm](https://togithub.com/vilmibm) . We are pleased to bring you a new release of the GitHub CLI on this Confusion 46, 3189 YOLD. We've got features. we've got bugfixes. This release has a real zest for life; can you feel it? First though, a sad note. [@​mislav](https://togithub.com/mislav) has moved on from GitHub. He was instrumental to this project and without him I don't think it would have ever happened. BIG THANKS MUCH LOVE to this wonderful person! Happily, we have a new core team member though who is, truly, a delight. Please welcome [@​williammartin](https://togithub.com/williammartin) , whom you'll see a lot more on issues and pull requests moving forward. Now, let's talk ***BUSINESS***. #### gh ruleset [Repository Rulesets](https://github.blog/changelog/2023-04-17-introducing-repository-rules-public-beta/) are in beta on git hub dot com and they are now also in beta on git hub sea ell eye. You can list, view, and check branches against rulesets set at the repository or organization level. Major shoutouts to [@​vaindil](https://togithub.com/vaindil) for this [big contribution](https://togithub.com/cli/cli/pull/7650). My favorite command in here in `gh rs check <branch>` which will tell you what rules would apply to a hypothetical branch name. To learn more, run `gh help ruleset`. #### gh cache `gh cache` is a new top level command in our suite of support for Actions. It lets you list and delete caches saved in Actions. It's [neat](https://togithub.com/cli/cli/pull/7403) and I like it. Thanks, [@​joshkraft](https://togithub.com/joshkraft) ! To learn more, run `gh help cache`. #### Other new stuff - Add option to remove file from gist by [@​kousikmitra](https://togithub.com/kousikmitra) in [cli/cli#7560 - Add remove/reset to auth refresh by [@​n1lesh](https://togithub.com/n1lesh) in [cli/cli#7597 - Small tweaks to auth refresh remove-scopes and reset-scopes flags by [@​samcoe](https://togithub.com/samcoe) in [cli/cli#7631 - make `gh pr create` behavior like `gh repo fork` by [@​leavesster](https://togithub.com/leavesster) in [cli/cli#7330 - chore: add title to iteration and milestone fields by [@​kamaz](https://togithub.com/kamaz) in [cli/cli#7621 - AutoFetch new branch created with gh issue develop by [@​shion1305](https://togithub.com/shion1305) in [cli/cli#7589 - feat: add statuscheck description to pr checks output by [@​jgrumboe](https://togithub.com/jgrumboe) in [cli/cli#7451 - Always show created gist privacy status. by [@​seanbright](https://togithub.com/seanbright) in [cli/cli#7645 - \[Codespaces] Support random `--server-port=0` and printing connection details by [@​josebalius](https://togithub.com/josebalius) in [cli/cli#7655 - gh release edit: support --verify-tag like gh release create by [@​rajhawaldar](https://togithub.com/rajhawaldar) in [cli/cli#7646 - Feature: Add `fill-first` flag to `pr create` command by [@​kousikmitra](https://togithub.com/kousikmitra) in [cli/cli#7398 - Return error on no-browser option if repo don't exists by [@​kousikmitra](https://togithub.com/kousikmitra) in [cli/cli#7314 #### Bugfixes - Early exit repo sync if merge-upstream requires workflow scope by [@​williammartin](https://togithub.com/williammartin) in [cli/cli#7612 - Don't deduplicate checks that stem from different events by [@​samcoe](https://togithub.com/samcoe) in [cli/cli#7618 - gh run cancel needs input validation by [@​rajhawaldar](https://togithub.com/rajhawaldar) in [cli/cli#7647 - Ensure gist edit request body matches desired schema by [@​williammartin](https://togithub.com/williammartin) in [cli/cli#7635 - fix(api): do not interpret "branch" placeholder when `GH_REPO` is set by [@​alex-petrov-vt](https://togithub.com/alex-petrov-vt) in [cli/cli#7626 - fix pr create crash on interactive milestone selection by [@​vilmibm](https://togithub.com/vilmibm) in [cli/cli#7666 - Fix issue develop command by [@​samcoe](https://togithub.com/samcoe) in [cli/cli#7656 #### Docs & Dev - docs: example of setting multiple vars using stdin by [@​iloveitaly](https://togithub.com/iloveitaly) in [cli/cli#7683 - Remove old code paths and improve code comments for `repo sync` by [@​samcoe](https://togithub.com/samcoe) in [cli/cli#7610 - Add tenancy support by [@​samcoe](https://togithub.com/samcoe) in [cli/cli#7636 - Update httpretty to released version by [@​josebalius](https://togithub.com/josebalius) in [cli/cli#7654 - build(deps): bump github.com/henvic/httpretty from 0.1.1 to 0.1.2 by [@​dependabot](https://togithub.com/dependabot) in [cli/cli#7657 - build(deps): bump google.golang.org/grpc from 1.49.0 to 1.53.0 by [@​dependabot](https://togithub.com/dependabot) in [cli/cli#7665 - Use SmartBaseRepoFunc for api command by [@​whi-tw](https://togithub.com/whi-tw) in [cli/cli#7594 - Clean up style nits and simplify some logic by [@​samcoe](https://togithub.com/samcoe) in [cli/cli#7687 - add gh cache to Actions explainer by [@​vilmibm](https://togithub.com/vilmibm) in [cli/cli#7689 #### New Contributors - [@​leavesster](https://togithub.com/leavesster) made their first contribution in [cli/cli#7330 - [@​kamaz](https://togithub.com/kamaz) made their first contribution in [cli/cli#7621 - [@​shion1305](https://togithub.com/shion1305) made their first contribution in [cli/cli#7589 - [@​jgrumboe](https://togithub.com/jgrumboe) made their first contribution in [cli/cli#7451 - [@​whi-tw](https://togithub.com/whi-tw) made their first contribution in [cli/cli#7594 - [@​seanbright](https://togithub.com/seanbright) made their first contribution in [cli/cli#7645 - [@​iloveitaly](https://togithub.com/iloveitaly) made their first contribution in [cli/cli#7683 **Full Changelog**: cli/cli@v2.31.0...v2.32.0 </details> <details> <summary>fluxcd/flux2 (fluxcd/flux2)</summary> ### [`v2.0.1`](https://togithub.com/fluxcd/flux2/releases/tag/v2.0.1) [Compare Source](https://togithub.com/fluxcd/flux2/compare/v2.0.0...v2.0.1) #### Highlights Flux `v2.0.1` is a patch release which comes with various fixes. Users are encouraged to upgrade for the best experience. :bulb: For upgrading from Flux `v0.x`, please see [the procedure documented in 2.0.0](https://togithub.com/fluxcd/flux2/releases/tag/v2.0.0). ##### Fixes - Fix AWS auth for cross-region ECR repositories (`source-controller`, `image-reflector-controller`). - Prevent spurious alerts for skipped resources (`kustomize-controller`). - List removed resources for `flux diff ks --kustomization-file` (`flux` CLI). - Fix SLSA provenance generation for the Flux CLI binaries. #### Components changelog - source-controller [v1.0.1](https://togithub.com/fluxcd/source-controller/blob/v1.0.1/CHANGELOG.md) - kustomize-controller [v1.0.1](https://togithub.com/fluxcd/kustomize-controller/blob/v1.0.1/CHANGELOG.md) - image-reflector-controller [v0.29.1](https://togithub.com/fluxcd/image-reflector-controller/blob/v0.29.1/CHANGELOG.md) #### CLI Changelog - PR [#​4068](https://togithub.com/fluxcd/flux2/issues/4068) - [@​stefanprodan](https://togithub.com/stefanprodan) - Update dependencies - PR [#​4065](https://togithub.com/fluxcd/flux2/issues/4065) - [@​hiddeco](https://togithub.com/hiddeco) - action: support `openssl` and `sha256sum` - PR [#​4062](https://togithub.com/fluxcd/flux2/issues/4062) - [@​souleb](https://togithub.com/souleb) - diff: Take into account the server-side inventory for local Flux Kustomizations - PR [#​4061](https://togithub.com/fluxcd/flux2/issues/4061) - [@​hiddeco](https://togithub.com/hiddeco) - action: re-allow configuration of non-default token - PR [#​4057](https://togithub.com/fluxcd/flux2/issues/4057) - [@​fluxcdbot](https://togithub.com/fluxcdbot) - Update toolkit components - PR [#​4052](https://togithub.com/fluxcd/flux2/issues/4052) - [@​stefanprodan](https://togithub.com/stefanprodan) - docs: Link to the Flux GitHub Action documentation - PR [#​4051](https://togithub.com/fluxcd/flux2/issues/4051) - [@​hiddeco](https://togithub.com/hiddeco) - action: use `$RUNNER_TOOL_CACHE`, support MacOS and Windows, validate checksum - PR [#​4046](https://togithub.com/fluxcd/flux2/issues/4046) - [@​stefanprodan](https://togithub.com/stefanprodan) - ci: backport: set write permissions - PR [#​4043](https://togithub.com/fluxcd/flux2/issues/4043) - [@​stefanprodan](https://togithub.com/stefanprodan) - ci: release: extract the image tag from GITHUB_REF - PR [#​4041](https://togithub.com/fluxcd/flux2/issues/4041) - [@​hiddeco](https://togithub.com/hiddeco) - ci: release: disable interpretation backslash esc #### New Documentation - [Flux GitHub Action](https://fluxcd.io/flux/flux-gh-action/) - [SLSA provenance verification](https://fluxcd.io/flux/security/slsa-assessment/#provenance-verification) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/scottames/dots). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi41LjMiLCJ1cGRhdGVkSW5WZXIiOiIzNi41LjMiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
bjw-s
pushed a commit
to bjw-s/dotfiles
that referenced
this pull request
Jul 14, 2023
](https://renovatebot.com){kind=link}
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [github-cli](https://togithub.com/cli/cli) | minor | `2.31.0` -> `2.32.0` | --- ### Release Notes <details> <summary>cli/cli (github-cli)</summary> ### [`v2.32.0`](https://togithub.com/cli/cli/releases/tag/v2.32.0): GitHub CLI 2.32.0 [Compare Source](https://togithub.com/cli/cli/compare/v2.31.0...v2.32.0) hello terminal fans, it's me [@​vilmibm](https://togithub.com/vilmibm) . We are pleased to bring you a new release of the GitHub CLI on this Confusion 46, 3189 YOLD. We've got features. we've got bugfixes. This release has a real zest for life; can you feel it? First though, a sad note. [@​mislav](https://togithub.com/mislav) has moved on from GitHub. He was instrumental to this project and without him I don't think it would have ever happened. BIG THANKS MUCH LOVE to this wonderful person! Happily, we have a new core team member who is, truly, a delight. Please welcome [@​williammartin](https://togithub.com/williammartin) , whom you'll see a lot more on issues and pull requests moving forward. Now, let's talk ***BUSINESS***. ##### gh ruleset [Repository Rulesets](https://github.blog/changelog/2023-04-17-introducing-repository-rules-public-beta/) are in beta on git hub dot com and they are now also in beta on git hub sea ell eye. You can list, view, and check branches against rulesets set at the repository or organization level. Major shoutouts to [@​vaindil](https://togithub.com/vaindil) for this [big contribution](https://togithub.com/cli/cli/pull/7650). My favorite command in here is `gh rs check <branch>` which will tell you what rules would apply to a hypothetical branch name. To learn more, run `gh help ruleset`. ##### gh cache `gh cache` is a new top level command in our suite of support for Actions. It lets you list and delete caches saved in Actions. It's [neat](https://togithub.com/cli/cli/pull/7403) and I like it. Thanks, [@​joshkraft](https://togithub.com/joshkraft) ! To learn more, run `gh help cache`. ##### Other new stuff - Add option to remove file from gist by [@​kousikmitra](https://togithub.com/kousikmitra) in [cli/cli#7560 - Add remove/reset to auth refresh by [@​n1lesh](https://togithub.com/n1lesh) in [cli/cli#7597 - Small tweaks to auth refresh remove-scopes and reset-scopes flags by [@​samcoe](https://togithub.com/samcoe) in [cli/cli#7631 - make `gh pr create` behavior like `gh repo fork` by [@​leavesster](https://togithub.com/leavesster) in [cli/cli#7330 - chore: add title to iteration and milestone fields by [@​kamaz](https://togithub.com/kamaz) in [cli/cli#7621 - AutoFetch new branch created with gh issue develop by [@​shion1305](https://togithub.com/shion1305) in [cli/cli#7589 - feat: add statuscheck description to pr checks output by [@​jgrumboe](https://togithub.com/jgrumboe) in [cli/cli#7451 - Always show created gist privacy status. by [@​seanbright](https://togithub.com/seanbright) in [cli/cli#7645 - \[Codespaces] Support random `--server-port=0` and printing connection details by [@​josebalius](https://togithub.com/josebalius) in [cli/cli#7655 - gh release edit: support --verify-tag like gh release create by [@​rajhawaldar](https://togithub.com/rajhawaldar) in [cli/cli#7646 - Feature: Add `fill-first` flag to `pr create` command by [@​kousikmitra](https://togithub.com/kousikmitra) in [cli/cli#7398 - Return error on no-browser option if repo don't exists by [@​kousikmitra](https://togithub.com/kousikmitra) in [cli/cli#7314 ##### Bugfixes - Early exit repo sync if merge-upstream requires workflow scope by [@​williammartin](https://togithub.com/williammartin) in [cli/cli#7612 - Don't deduplicate checks that stem from different events by [@​samcoe](https://togithub.com/samcoe) in [cli/cli#7618 - gh run cancel needs input validation by [@​rajhawaldar](https://togithub.com/rajhawaldar) in [cli/cli#7647 - Ensure gist edit request body matches desired schema by [@​williammartin](https://togithub.com/williammartin) in [cli/cli#7635 - fix(api): do not interpret "branch" placeholder when `GH_REPO` is set by [@​alex-petrov-vt](https://togithub.com/alex-petrov-vt) in [cli/cli#7626 - fix pr create crash on interactive milestone selection by [@​vilmibm](https://togithub.com/vilmibm) in [cli/cli#7666 - Fix issue develop command by [@​samcoe](https://togithub.com/samcoe) in [cli/cli#7656 ##### Docs & Dev - docs: example of setting multiple vars using stdin by [@​iloveitaly](https://togithub.com/iloveitaly) in [cli/cli#7683 - Remove old code paths and improve code comments for `repo sync` by [@​samcoe](https://togithub.com/samcoe) in [cli/cli#7610 - Update httpretty to released version by [@​josebalius](https://togithub.com/josebalius) in [cli/cli#7654 - build(deps): bump github.com/henvic/httpretty from 0.1.1 to 0.1.2 by [@​dependabot](https://togithub.com/dependabot) in [cli/cli#7657 - build(deps): bump google.golang.org/grpc from 1.49.0 to 1.53.0 by [@​dependabot](https://togithub.com/dependabot) in [cli/cli#7665 - Use SmartBaseRepoFunc for api command by [@​whi-tw](https://togithub.com/whi-tw) in [cli/cli#7594 - Clean up style nits and simplify some logic by [@​samcoe](https://togithub.com/samcoe) in [cli/cli#7687 - add gh cache to Actions explainer by [@​vilmibm](https://togithub.com/vilmibm) in [cli/cli#7689 ##### New Contributors - [@​leavesster](https://togithub.com/leavesster) made their first contribution in [cli/cli#7330 - [@​kamaz](https://togithub.com/kamaz) made their first contribution in [cli/cli#7621 - [@​shion1305](https://togithub.com/shion1305) made their first contribution in [cli/cli#7589 - [@​jgrumboe](https://togithub.com/jgrumboe) made their first contribution in [cli/cli#7451 - [@​whi-tw](https://togithub.com/whi-tw) made their first contribution in [cli/cli#7594 - [@​seanbright](https://togithub.com/seanbright) made their first contribution in [cli/cli#7645 - [@​iloveitaly](https://togithub.com/iloveitaly) made their first contribution in [cli/cli#7683 **Full Changelog**: cli/cli@v2.31.0...v2.32.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi43LjAiLCJ1cGRhdGVkSW5WZXIiOiIzNi43LjEiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=--> Co-authored-by: bjw-s-bot <87358111+bjw-s-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #7595
The placeholder
{repo}was previously substituted with whichever remote happened to be sorted first viasort.Sort(). Instead:$GH_REPOis not set, useSmartBaseRepoFuncto select the remote the user has configured viarepo set-default.$GH_REPOis set, useOverrideBaseRepoFuncas before.