pass apiClient to determineBaseRepo #943
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #914
It is Mislav's and my hypothesis that the failed reauth issue was caused by having multiple
apiClient
instances during a command's lifetime. The secondapiClient
s are created inside ofdetermineBaseRepo
; this PR changesdetermineBaseRepo
to just accept a pre-existingapiClient
.It was only creating its own to begin with in an attempt to reduce the length of its function
signature and for no other reason.