Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pass apiClient to determineBaseRepo #943

Merged
merged 1 commit into from May 18, 2020
Merged

pass apiClient to determineBaseRepo #943

merged 1 commit into from May 18, 2020

Commits on May 15, 2020

  1. pass apiClient to determineBaseRepo 

    Our code had an unspoken assumption that only one apiClient is created
during the course of a command. Violating this assumption is fine in
almost all cases, but not when we need to do a re-auth to add a new
oauth scope to a user's token.

There is likely a more elegant solution to the problem but until then
this changes determineBaseRepo to use an existing apiClient.
    @vilmibm
    vilmibm committed May 15, 2020
    Configuration menu
    Copy the full SHA
    c8c807b View commit details
    Browse the repository at this point in the history