Chore: Permit installation on Python 3.7 and higher #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rationale: While Python 3.7 is already end-of-life, some people still need to support it. Because `click-aliases` is often pulled into projects using click, it is very common, and as such, currently imposes a restriction which might not exactly be necessary. It would be sad needing to vendor the code only to support Python 3.7 for people who need it.
|
released 1.0.4 |
|
Thank you so much! 🌻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Robbin,
because you have been so supportive with our recent patch GH-13, we hope you can support us on this one as well. It will adjust the project metadata to also permit installation on Python 3.7.
Rationale: While Python 3.7 is already end-of-life, some people still need to support it. Because
click-aliasesis often pulled into projects using click, it is very common, and as such, currently imposes a restriction which might not exactly be necessary.It would be so sad needing to vendor the code only to support Python 3.7 for people who need it. 1
With kind regards,
Andreas.
Footnotes
Full disclaimer: It's eventually ourselves. ;] https://github.com/crate/crash/pull/410#issuecomment-1824260748 ↩