Merged #62 #65 #69 and added tests using gh-actions #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added some badges
Added 3.7 - 3.11 python versions for tox and 3.10, 3.11 for travis
Added pytest gh-actions text: .github/workflows/tests.yml modified: .gitignore modified: MANIFEST.in modified: Makefile deleted: bin/testrepl.py modified: pyproject.toml new file: requirements/requirements.txt new file: requirements/requirements_dev.txt modified: setup.cfg modified: setup.py Moved Code to utils.py: src/click_repl/__init__.py For mypy: src/click_repl/py.typed
Bumped actions version: .github/workflows/tests.yml modified: setup.cfg new file: src/click_repl/exceptions.py new file: src/click_repl/utils.py modified: tox.ini
Dropped click version to 7: setup.cfg modified: src/click_repl/__init__.py modified: tests/test_basic.py modified: tests/test_command_collection.py Added one more env for clickv7: tox.ini
removed flake8 test: .github/workflows/tests.yml modified: pyproject.toml improved code: src/click_repl/utils.py conftest for pytest: tests/conftest.py improved test cases: tests/test_basic.py improved test cases: tests/test_command_collection.py improved test cases: tests/test_complete.py improved test cases: tests/test_dev.py improved test cases: tests/test_repl/test_repl.py modified: tox.ini
deleted: click_repl/exceptions.py deleted: click_repl/py.typed modified: pyproject.toml modified: setup.cfg modified: tests/conftest.py deleted: tests/test_argument.py modified: tests/test_complete.py deleted: tests/test_dev.py new file: tests/test_dev/test_get_internal_cmds.py new file: tests/test_dev/test_internal_cmds.py new file: tests/test_dev/test_register_internal_cmds.py new file: tests/test_dev/test_sys_cmds.py new file: tests/test_repl.py deleted: tests/test_repl/test_repl.py
modified: tests/test_dev/test_get_internal_cmds.py modified: tests/test_dev/test_internal_cmds.py modified: tests/test_dev/test_sys_cmds.py modified: tests/test_repl.py
modified: requirements/requirements_dev.txt modified: setup.cfg modified: tox.ini
…ick-repl into GhostOps77-patch-1
auvipy
requested changes
Feb 2, 2023
|
@auvipy |
|
yes we can start with the new CI first |
|
you can pull from master |
More test cases: tests/test_basic.py More test cases: tests/test_complete.py
Organised tests: tests/test_complete.py
modified: tests/test_basic.py modified: tests/test_complete.py
modified for flake8 tests: tests/test_complete.py modified for flake8 tests: tests/test_dev/test_get_internal_cmds.py modified for flake8 tests: tests/test_dev/test_register_internal_cmds.py
test for gh actions formatter: src/click_repl/utils.py
…ick-repl into GhostOps77-patch-1
…ick-repl into GhostOps77-patch-1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've did so many changes in this repo
I've merged all those PR's and gave some test cases, that run in pytest and tox
And that still give only 75% of coverage in pytest results, cuz some testing should be done by passing in command line arguments, which is impossible with this type of code structure
I tried my best to cover the test cases for each PR, but the code still needs some restructuring, which can maybe provide an opportunity to run command line argument tests in pytest
I've also made test cases for click v7.1.2 (cuz I saw that this module supports click v7)
Ignore the blank/auto name suggested commits, It's just me being lazy