Added flake8 tests and some config files #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added test passing badges and more: README.md Moved content to .md file: README.rst Added setuptoold build config: pyproject.toml new config file: setup.cfg Moved config to .cfg file: setup.py Moved code to src folder: click_repl/__init__.py -> src/click_repl/__init__.py Moved code to src folder: click_repl/exceptions.py -> src/click_repl/exceptions.py modified by black: tests/test_argument.py modified by black: tests/test_basic.py modified by black: tests/test_command_collection.py modified by black: tests/test_repl.py Added flake8 test: tox.ini
|
@auvipy Is this PR has too much to merge in? |
auvipy
requested changes
Feb 3, 2023
src/click_repl/__init__.py
Outdated
| @@ -10,20 +10,24 @@ | |||
| from .exceptions import InternalCommandException, ExitReplException # noqa | |||
|
|
|||
| # Handle backwards compatibility between Click 7.0 and 8.0 | |||
There was a problem hiding this comment.
i don't think we need to move this to src
There was a problem hiding this comment.
ok moving it out as u wish
renamed: src/click_repl/exceptions.py -> click_repl/exceptions.py removed package_src attribute: setup.cfg modified flake8 command: tox.ini
auvipy
approved these changes
Feb 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm just gonna stick with flake8 for now
Changes that I've done here:
click_replfolder intosrcfoldersetup.cfgfile that has all the setuptools, and flake8 config.flake8README.rsttoREADME.mdsrcandtestsfolder with black, so that they can pass flake8 test