Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove some merging streams #29768

Merged
merged 8 commits into from
Oct 8, 2021
Merged

Remove some merging streams #29768

merged 8 commits into from
Oct 8, 2021

Conversation

KochetovNicolai
Copy link
Member

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

@robot-clickhouse robot-clickhouse added the pr-not-for-changelog This PR should not be mentioned in the changelog label Oct 5, 2021
@nikitamikhaylov nikitamikhaylov self-assigned this Oct 5, 2021
@KochetovNicolai
Copy link
Member Author

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Oct 5, 2021

Command update: success

Branch has been successfully updated

KochetovNicolai
KochetovNicolai commented Oct 8, 2021
View reviewed changes
Copy link
Member Author

@KochetovNicolai KochetovNicolai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@KochetovNicolai
Copy link
Member Author

Failed integration tests are flaky or failed in docker like

E               Exception: Command ['docker', 'exec', 'roottestbackuprestore_node_1', 'cp', '-r', '/var/lib/clickhouse/shadow/2/data/test/tbl', '-T', '/var/lib/clickhouse/data/test/tbl3/detached'] return non-zero code 1: cp: cannot stat '/var/lib/clickhouse/shadow/2/data/test/tbl': No such file or directory

@KochetovNicolai KochetovNicolai merged commit 9eddee5 into master Oct 8, 2021
@KochetovNicolai KochetovNicolai deleted the remove-merging-streams branch October 8, 2021 10:15
azat added a commit to azat/ClickHouse that referenced this pull request Oct 14, 2021
@azat
Remove unused Block member from MutateTask
e4b39ca 
v0: Fix excessive memory usage in MutateTask
    This is relevant only for 01200_mutations_memory_consumption test, since
    this is just a block.
v2: just remove unused Block member, since other part had been fixed in ClickHouse#29768
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikitamikhaylov nikitamikhaylov

Labels
pr-not-for-changelog This PR should not be mentioned in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@KochetovNicolai @nikitamikhaylov @robot-clickhouse