Fix use quota bug #31656
Merged
Fix use quota bug #31656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitlibar
reviewed
Dec 5, 2021
vitlibar
reviewed
Dec 5, 2021
vitlibar
reviewed
Dec 10, 2021
tests/integration/test_quota/test.py
Outdated
| @@ -393,30 +393,45 @@ def test_query_inserts(): | |||
|
|
|||
|
|
|||
| def test_consumption_of_show_tables(): | |||
| assert re.match( | |||
| "myQuota\\tdefault\\t.*\\t31556952\\t0\\t1000\\t0\\t.*\\t\\\\N.*", | |||
| instance.query("SHOW QUOTA")) | |||
There was a problem hiding this comment.
No, SHOW TABLES should use and check quota correctly no matter if SHOW QUOTA was called before SHOW TABLES or not.
There was a problem hiding this comment.
This PR along with #32575 must fix the issue.
There was a problem hiding this comment.
tks，the problem has been solved
vitlibar
added
the
can be tested
|
@Mergifyio update |
✅ Branch has been successfully updated |
vitlibar
added
the
pr-must-backport
This was referenced Dec 13, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Dec 13, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Dec 13, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Dec 13, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Dec 13, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Dec 13, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Dec 13, 2021
alexey-milovidov
added a commit
that referenced
this pull request
Dec 14, 2021
Backport #31656 to 21.12: Fix use quota bug
vitlibar
pushed a commit
that referenced
this pull request
Dec 14, 2021
Backport #31656 to 21.11: Fix use quota bug
vitlibar
pushed a commit
that referenced
this pull request
Dec 14, 2021
Backport #31656 to 21.10: Fix use quota bug
vitlibar
pushed a commit
that referenced
this pull request
Dec 14, 2021
Backport #31656 to 21.9: Fix use quota bug
vitlibar
pushed a commit
that referenced
this pull request
Dec 14, 2021
Backport #31656 to 21.3: Fix use quota bug
vitlibar
pushed a commit
that referenced
this pull request
Dec 14, 2021
Backport #31656 to 21.8: Fix use quota bug
Felixoid
added
the
pr-backports-created
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Bug Fix
Changelog entry:
Quota limit was not reached, but the limit was exceeded. This PR fixes #31174
this PR #31337
this change does not solve the problem，need_reset_counters the first time is still false，I think the first time the limit is exceeded, used should be reset to 0 @vitlibar