Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix aliases with positional args enabled #31741

Merged
merged 3 commits into from
Nov 30, 2021

Conversation

kssenii
Copy link
Member

@kssenii kssenii commented Nov 24, 2021

Changelog category (leave one):

  • Bug Fix (user-visible misbehaviour in official stable or prestable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix group by / order by / limit by aliases with positional arguments enabled. Closes #31173.

@robot-clickhouse robot-clickhouse added the pr-bugfix Pull request with bugfix, not backported by default label Nov 24, 2021
@novikd novikd self-assigned this Nov 26, 2021
@kssenii
Copy link
Member Author

kssenii commented Nov 29, 2021

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Nov 29, 2021

update

✅ Branch has been successfully updated

@kssenii
Copy link
Member Author

kssenii commented Nov 30, 2021

Integration tests (asan, actions) — fail: 8 -- failed because of docker issues

1. test_backward_compatibility
>               raise Exception(f"Command {args} return non-zero code {res.returncode}: {res.stderr.decode('utf-8')}")
E               Exception: Command ['docker-compose', '--env-file', '/ClickHouse/tests/integration/test_backward_compatibility/_instances_skipping_indices_0/.env', '--project-name', 'roottestbackwardcompatibilityskippingindices', '--file', '/ClickHouse/tests/integration/test_backward_compatibility/_instances_skipping_indices_0/node/docker-compose.yml', 'up', '-d', '--no-recreate'] return non-zero code 1: Building with native build. Learn about native build in Compose here: https://docs.docker.com/go/compose-native-build/

2. test_storage_url and test_disk_over_web_server
>               raise Exception(f"Command {args} return non-zero code {res.returncode}: {res.stderr.decode('utf-8')}")
E               Exception: Command ['docker-compose', '--env-file', '/ClickHouse/tests/integration/test_storage_url/_instances_0/.env', '--project-name', 'rootteststorageurl', '--file', '/compose/docker_compose_nginx.yml', '--verbose', 'up', '-d', '--renew-anon-volumes'] return non-zero code 1: compose.config.config.find: Using configuration files: /compose/docker_compose_nginx.yml

01154_move_partition_long -- known flacky test

@kssenii kssenii requested a review from novikd November 30, 2021 09:17
@kssenii kssenii merged commit a515767 into ClickHouse:master Nov 30, 2021
kssenii added a commit that referenced this pull request Dec 1, 2021
Backport #31741 to 21.10: Fix aliases with positional args enabled
kssenii added a commit that referenced this pull request Dec 1, 2021
Backport #31741 to 21.11: Fix aliases with positional args enabled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix Pull request with bugfix, not backported by default
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enable_positional_arguments doesnt work with substr(key, 10)
3 participants