Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sections and clean up Distributed documentation #32532

Merged
merged 2 commits into from
Dec 13, 2021

Conversation

cwurm
Copy link
Contributor

@cwurm cwurm commented Dec 10, 2021

Changelog category (leave one):

  • Documentation (changelog entry is not required)

Detailed description / Documentation draft:

Unlike the docs for most other table engines, the Distributed table does not have proper sections and headings and does not specify the syntax at the top of the page. I look at this page quite a lot so I did a fast pass through it, added what I thought was missing: table syntax, sections with headings, fixed some formatting of lists, backticked a lot of special words, and clarified some language here and there. Hopefully, this will make it easier to read and understand.

@robot-clickhouse robot-clickhouse added the pr-documentation Documentation PRs for the specific code PR label Dec 10, 2021
@alexey-milovidov alexey-milovidov added the can be tested Allows running workflows for external contributors label Dec 11, 2021
@alesapin
Copy link
Member

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Dec 13, 2021

update

✅ Branch has been successfully updated

Copy link
Member

@vdimir vdimir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vdimir vdimir merged commit 66e1fb7 into ClickHouse:master Dec 13, 2021
@vdimir vdimir self-assigned this Dec 13, 2021
@cwurm cwurm deleted the docs_distributed_sections branch December 13, 2021 11:06
@ka1bi4
Copy link
Contributor

ka1bi4 commented Dec 14, 2021

Internal documentation ticket: DOCSUP-20063

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
can be tested Allows running workflows for external contributors pr-documentation Documentation PRs for the specific code PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants