Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Randomize some settings in functional tests #34092

Merged
merged 20 commits into from
Mar 4, 2022

Conversation

Avogar
Copy link
Member

@Avogar Avogar commented Jan 28, 2022

Changelog category (leave one):

  • Build/Testing/Packaging Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Randomize some settings in functional tests. This closes #32268.

@robot-clickhouse robot-clickhouse added the pr-build Pull request with build/testing/packaging improvement label Jan 28, 2022
@alexey-milovidov alexey-milovidov self-assigned this Jan 28, 2022
@alexey-milovidov
Copy link
Member

optimize_move_to_prewhere = 0|1

@alexey-milovidov
Copy link
Member

prefer_localhost_replica = 0|1

@alexey-milovidov
Copy link
Member

group_by_two_level_threshold
group_by_two_level_threshold_bytes

With 10% probability set to very low value (to activate always) and with 10% set to very high value (to never activate)

@alexey-milovidov
Copy link
Member

distributed_aggregation_memory_efficient = 0|1

@alexey-milovidov
Copy link
Member

allow_experimental_parallel_reading_from_replicas = 0|1

@alexey-milovidov
Copy link
Member

max_insert_threads with probability 1/2 set it uniformly random 1..16

@alexey-milovidov
Copy link
Member

output_format_parallel_formatting = 0|1

@alexey-milovidov
Copy link
Member

PS. We can adapt existing tests then add more randomization in subsequent PR.

@alexey-milovidov
Copy link
Member

@den-crane @SaltTan Maybe you can recall some problematic settings from your experience.

@tavplubix
Copy link
Member

We should print changed settings somewhere in logs to simplify debugging

Co-authored-by: tavplubix <tavplubix@gmail.com>
tests/clickhouse-test Outdated Show resolved Hide resolved
@Algunenano
Copy link
Member

Love the idea but do you really want to introduce them all at once? The last similar thing done was to run under a random timezone and it took weeks and many PRs to stabilize things.

@alexey-milovidov
Copy link
Member

I'm ok if it will take weeks.

@Avogar Avogar added the force tests The label does nothing, NOOP, None, nil label Feb 15, 2022
@Avogar
Copy link
Member Author

Avogar commented Feb 28, 2022

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Feb 28, 2022

update

✅ Branch has been successfully updated

@SaltTan
Copy link
Contributor

SaltTan commented Mar 1, 2022

@den-crane @SaltTan Maybe you can recall some problematic settings from your experience.

I'm sorry it took me so long.

  • optimize*
  • enable*
  • use*
  • compile_aggregate_expressions
  • compile_expressions
  • There was an issue with 'read_backoff' once.

@Avogar
Copy link
Member Author

Avogar commented Mar 3, 2022

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Mar 3, 2022

update

✅ Branch has been successfully updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
force tests The label does nothing, NOOP, None, nil pr-build Pull request with build/testing/packaging improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Randomization of settings in functional tests.
7 participants