-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Randomize some settings in functional tests #34092
Conversation
optimize_move_to_prewhere = 0|1 |
prefer_localhost_replica = 0|1 |
group_by_two_level_threshold With 10% probability set to very low value (to activate always) and with 10% set to very high value (to never activate) |
distributed_aggregation_memory_efficient = 0|1 |
allow_experimental_parallel_reading_from_replicas = 0|1 |
max_insert_threads with probability 1/2 set it uniformly random 1..16 |
output_format_parallel_formatting = 0|1 |
PS. We can adapt existing tests then add more randomization in subsequent PR. |
@den-crane @SaltTan Maybe you can recall some problematic settings from your experience. |
We should print changed settings somewhere in logs to simplify debugging |
Co-authored-by: tavplubix <tavplubix@gmail.com>
… to CLICKHOUSE_URL_PARAMS
Love the idea but do you really want to introduce them all at once? The last similar thing done was to run under a random timezone and it took weeks and many PRs to stabilize things. |
I'm ok if it will take weeks. |
@Mergifyio update |
✅ Branch has been successfully updated |
I'm sorry it took me so long.
|
@Mergifyio update |
✅ Branch has been successfully updated |
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Randomize some settings in functional tests. This closes #32268.