Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple client connection attempts if hostname resolves to multiple addresses #37273

Merged
merged 3 commits into from
May 19, 2022
Merged

Multiple client connection attempts if hostname resolves to multiple addresses #37273

merged 3 commits into from
May 19, 2022

Conversation

yakov-olkhovskiy
Copy link
Member

@yakov-olkhovskiy yakov-olkhovskiy commented May 16, 2022 •
edited by alexey-milovidov

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Client will try every IP address returned by DNS resolution until successful connection.

closes #6698

@yakov-olkhovskiy yakov-olkhovskiy added pr-bugfix Pull request with bugfix, not backported by default can be tested Allows running workflows for external contributors labels May 16, 2022
@antonio2368 antonio2368 self-assigned this May 17, 2022
antonio2368
antonio2368 reviewed May 17, 2022
View reviewed changes
src/Client/Connection.cpp Outdated Show resolved Hide resolved
src/Client/Connection.cpp Outdated Show resolved Hide resolved
src/Common/DNSResolver.cpp Show resolved Hide resolved
@yakov-olkhovskiy
Copy link
Member Author

@mergify update

@mergify
Copy link
Contributor

mergify bot commented May 18, 2022

update

✅ Branch has been successfully updated

@yakov-olkhovskiy yakov-olkhovskiy removed the pr-bugfix Pull request with bugfix, not backported by default label May 19, 2022
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-bugfix Pull request with bugfix, not backported by default label May 19, 2022
@yakov-olkhovskiy yakov-olkhovskiy removed the pr-bugfix Pull request with bugfix, not backported by default label May 19, 2022
@robot-ch-test-poll robot-ch-test-poll added the pr-bugfix Pull request with bugfix, not backported by default label May 19, 2022
@yakov-olkhovskiy yakov-olkhovskiy merged commit cd2ae72 into master May 19, 2022
@yakov-olkhovskiy yakov-olkhovskiy deleted the client-dns-list branch May 19, 2022 05:50
@alexey-milovidov alexey-milovidov added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label Jun 1, 2022
@robot-ch-test-poll2 robot-ch-test-poll2 added pr-improvement Pull request with some product improvements and removed pr-bugfix Pull request with bugfix, not backported by default labels Jun 1, 2022
This was referenced Jun 1, 2022
Merged
Closed
Merged
Closed
robot-clickhouse pushed a commit that referenced this pull request Jun 1, 2022
Backport #37273 to 22.5: Multiple client connection attempts if hostn…
5ba3beb 
…ame resolves to multiple addresses
@robot-clickhouse robot-clickhouse mentioned this pull request Jun 1, 2022
Closed
robot-clickhouse pushed a commit that referenced this pull request Jun 1, 2022
Backport #37273 to 22.4: Multiple client connection attempts if hostn…
9d4bd6e 
…ame resolves to multiple addresses
@robot-clickhouse robot-clickhouse mentioned this pull request Jun 1, 2022
Closed
@robot-ch-test-poll robot-ch-test-poll added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Jul 28, 2022
@tavplubix tavplubix mentioned this pull request Aug 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonio2368 antonio2368 antonio2368 approved these changes

Assignees

@antonio2368 antonio2368

Labels
can be tested Allows running workflows for external contributors pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-improvement Pull request with some product improvements pr-must-backport Pull request should be backported intentionally. Use this label with great care!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clickhouse client uses only first resolved ip from localhost
6 participants
@yakov-olkhovskiy @antonio2368 @alexey-milovidov @robot-ch-test-poll @robot-ch-test-poll1 @robot-ch-test-poll2