New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix an invalid type of a column after attach and alter. #42319
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-ch-test-poll2
added
the
pr-bugfix
Pull request with bugfix, not backported by default
label
Oct 14, 2022
KochetovNicolai
added
the
pr-must-backport
Pull request should be backported intentionally. Use this label with great care!
label
Oct 14, 2022
Stateless tests flaky check (asan) - new added test can be a little slow, it's ok Stress test (ubsan) - intersecting parts, need investigation |
This was referenced Oct 17, 2022
robot-clickhouse
pushed a commit
that referenced
this pull request
Oct 17, 2022
robot-clickhouse
pushed a commit
that referenced
this pull request
Oct 17, 2022
robot-clickhouse
pushed a commit
that referenced
this pull request
Oct 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
KochetovNicolai
added a commit
that referenced
this pull request
Oct 18, 2022
Backport #42319 to 22.9: Fix an invalid type of a column after attach and alter.
KochetovNicolai
added a commit
that referenced
this pull request
Oct 18, 2022
Backport #42319 to 22.8: Fix an invalid type of a column after attach and alter.
KochetovNicolai
added a commit
that referenced
this pull request
Oct 18, 2022
Backport #42319 to 22.7: Fix an invalid type of a column after attach and alter.
robot-ch-test-poll1
added
the
pr-backports-created
Backport PRs are successfully created, it won't be processed by CI script anymore
label
Oct 18, 2022
ucasfl
pushed a commit
to ucasfl/ClickHouse
that referenced
this pull request
Nov 30, 2022
…wrong-type Fix an invalid type of a column after attach and alter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr-backports-created
Backport PRs are successfully created, it won't be processed by CI script anymore
pr-bugfix
Pull request with bugfix, not backported by default
pr-must-backport
Pull request should be backported intentionally. Use this label with great care!
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
ALTER UPDATE
of attached part (with columns different from table schema) could create an invalidcolumns.txt
metadata on disk. Reading from such part could fail with errors or return invalid data. Fixes #42161.