Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an invalid type of a column after attach and alter. #42319

Merged
merged 2 commits into from Oct 17, 2022

Conversation

KochetovNicolai
Copy link
Member

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in official stable or prestable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

ALTER UPDATE of attached part (with columns different from table schema) could create an invalid columns.txt metadata on disk. Reading from such part could fail with errors or return invalid data. Fixes #42161.

@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-bugfix Pull request with bugfix, not backported by default label Oct 14, 2022
@KochetovNicolai KochetovNicolai added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label Oct 14, 2022
@SmitaRKulkarni SmitaRKulkarni self-assigned this Oct 17, 2022
@KochetovNicolai
Copy link
Member Author

#41934

Stateless tests flaky check (asan) - new added test can be a little slow, it's ok

Stress test (ubsan) - intersecting parts, need investigation

@KochetovNicolai KochetovNicolai merged commit c9aa6a6 into master Oct 17, 2022
@KochetovNicolai KochetovNicolai deleted the fix-alter-update-wrong-type branch October 17, 2022 10:44
robot-clickhouse pushed a commit that referenced this pull request Oct 17, 2022
robot-clickhouse pushed a commit that referenced this pull request Oct 17, 2022
robot-clickhouse pushed a commit that referenced this pull request Oct 17, 2022
Copy link
Member

@SmitaRKulkarni SmitaRKulkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

KochetovNicolai added a commit that referenced this pull request Oct 18, 2022
Backport #42319 to 22.9: Fix an invalid type of a column after attach and alter.
KochetovNicolai added a commit that referenced this pull request Oct 18, 2022
Backport #42319 to 22.8: Fix an invalid type of a column after attach and alter.
KochetovNicolai added a commit that referenced this pull request Oct 18, 2022
Backport #42319 to 22.7: Fix an invalid type of a column after attach and alter.
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Oct 18, 2022
ucasfl pushed a commit to ucasfl/ClickHouse that referenced this pull request Nov 30, 2022
…wrong-type

Fix an invalid type of a column after attach and alter.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-bugfix Pull request with bugfix, not backported by default pr-must-backport Pull request should be backported intentionally. Use this label with great care!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

alter update "corrupts" collumns.txt
4 participants