-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deltalake/iceberg/hudi improvements #47307
deltalake/iceberg/hudi improvements #47307
Conversation
ead85a7
to
e832457
Compare
d03d6de
to
89edd80
Compare
89edd80
to
0240ad4
Compare
can a test be added for partitioned delta tables? |
what about support for deltalake timetravel |
yes, but not in this PR, could you please create an issue feature request for this? |
Also, it worth to support reading the table with cluster. |
a5de483
to
13f29a7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial review of the code only, didn't check tests.
Looks really clean, good job!
@alifirat, when I and some other people tested it - it did not work. I checked what changes I made to make it work and looks like it was able to work only if data was partitioned (because it incorrectly worked with paths). |
4513857
to
0c8d65b
Compare
2e2c634
to
6f53784
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
not related to changes
|
Hi @kssenii I just see that you have merged this PR. Do you think it's going to be available in your monthly release or backport to the existing releases ? Thanks ! |
@alifirat, it will be available only in the next release, to the existing releases it will not be backported. |
For Iceberg V2, it may have delete files, current implementation seems can not handle it. |
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Several improvements around data lakes: