Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fuzzer of data formats #47519

Merged
merged 55 commits into from
Mar 20, 2023
Merged

Fuzzer of data formats #47519

merged 55 commits into from
Mar 20, 2023

Conversation

alexey-milovidov
Copy link
Member

@alexey-milovidov alexey-milovidov commented Mar 13, 2023

Changelog category (leave one):

  • Bug Fix

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Add a fuzzer for data formats, data types, and serialized aggregate functions. This closes #47518. This closes #47720. The deserialization of some aggregate functions was unsafe: the functions for roaring bitmaps didn't check the bounds and allowed a buffer overflow. The roaring bitmaps library is updated to the latest version. The function quantileTiming was not exception safe after deserializing invalid data: it had an incorrect call to memory free. The function topK had a memory leak after processing invalid data. Replace low-level exceptions "Too large size passed to the allocator" with more high-level exceptions like "Too large array size" by adding early checks (both are safe, but the former is considered as an assertion in the debug build). Backward incompatible change: it was allowed to specify meaningless arguments for data types Bool, Point, Ring, Polygon, MultiPolygon like Bool(Upyachka) or Bool(), but not anymore.

@robot-clickhouse robot-clickhouse added the pr-build Pull request with build/testing/packaging improvement label Mar 13, 2023
@alexey-milovidov
Copy link
Member Author

#47518

@Avogar Avogar self-assigned this Mar 13, 2023
@alexey-milovidov
Copy link
Member Author

#47540

@robot-ch-test-poll1 robot-ch-test-poll1 added the submodule changed At least one submodule changed in this PR. label Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-build Pull request with build/testing/packaging improvement submodule changed At least one submodule changed in this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Meaningless type names are allowed. Logical error on incorrect DEFAULT in CREATE query
4 participants