-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fuzzer of data formats #47519
Merged
Merged
Fuzzer of data formats #47519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-clickhouse
added
the
pr-build
Pull request with build/testing/packaging improvement
label
Mar 13, 2023
robot-ch-test-poll1
added
the
submodule changed
At least one submodule changed in this PR.
label
Mar 19, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr-build
Pull request with build/testing/packaging improvement
submodule changed
At least one submodule changed in this PR.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Add a fuzzer for data formats, data types, and serialized aggregate functions. This closes #47518. This closes #47720. The deserialization of some aggregate functions was unsafe: the functions for roaring bitmaps didn't check the bounds and allowed a buffer overflow. The roaring bitmaps library is updated to the latest version. The function
quantileTiming
was not exception safe after deserializing invalid data: it had an incorrect call to memory free. The functiontopK
had a memory leak after processing invalid data. Replace low-level exceptions "Too large size passed to the allocator" with more high-level exceptions like "Too large array size" by adding early checks (both are safe, but the former is considered as an assertion in the debug build). Backward incompatible change: it was allowed to specify meaningless arguments for data typesBool
,Point
,Ring
,Polygon
,MultiPolygon
likeBool(Upyachka)
orBool()
, but not anymore.