-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not build sets for skip indexes if they are not used #48299
Merged
robot-clickhouse-ci-1
merged 3 commits into
ClickHouse:master
from
CurtizJ:do-not-build-unnecessary-sets
Apr 8, 2023
Merged
Do not build sets for skip indexes if they are not used #48299
robot-clickhouse-ci-1
merged 3 commits into
ClickHouse:master
from
CurtizJ:do-not-build-unnecessary-sets
Apr 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-ch-test-poll2
added
the
pr-performance
Pull request with some performance improvements
label
Mar 31, 2023
nickitat
approved these changes
Apr 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perf test?
alexey-milovidov
approved these changes
Apr 8, 2023
Enmk
pushed a commit
to Altinity/ClickHouse
that referenced
this pull request
Jun 12, 2023
…sary-sets Do not build sets for skip indexes if they are not used
Enmk
pushed a commit
to Altinity/ClickHouse
that referenced
this pull request
Jun 19, 2023
…sary-sets Do not build sets for skip indexes if they are not used
Enmk
added a commit
to Altinity/ClickHouse
that referenced
this pull request
Jun 21, 2023
…uild_skip_indices_if_not_used 23.3 backport of ClickHouse#48299 Do not build skip indices if not used
This was referenced Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Do not build set for the right side of
IN
clause with subquery when it is used only for analysis of skip indexes and they are disabled by setting (use_skip_indexes=0
). Previously it might affect the performance of queries.Fixes #47947.