Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not build sets for skip indexes if they are not used #48299

Merged

Conversation

CurtizJ
Copy link
Member

@CurtizJ CurtizJ commented Mar 31, 2023

Changelog category (leave one):

  • Performance Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Do not build set for the right side of IN clause with subquery when it is used only for analysis of skip indexes and they are disabled by setting (use_skip_indexes=0). Previously it might affect the performance of queries.

Fixes #47947.

@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-performance Pull request with some performance improvements label Mar 31, 2023
@nickitat nickitat self-assigned this Apr 1, 2023
Copy link
Member

@nickitat nickitat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perf test?

@robot-clickhouse-ci-1 robot-clickhouse-ci-1 merged commit 3302f1f into ClickHouse:master Apr 8, 2023
138 checks passed
Enmk pushed a commit to Altinity/ClickHouse that referenced this pull request Jun 12, 2023
…sary-sets

Do not build sets for skip indexes if they are not used
Enmk pushed a commit to Altinity/ClickHouse that referenced this pull request Jun 19, 2023
…sary-sets

Do not build sets for skip indexes if they are not used
Enmk added a commit to Altinity/ClickHouse that referenced this pull request Jun 21, 2023
…uild_skip_indices_if_not_used

23.3 backport of ClickHouse#48299 Do not build skip indices if not used
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-performance Pull request with some performance improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ClickHouse spends time in makeSetsForIndex for skip index with use_skip_indexes=0
5 participants