Cleanup moving parts

[vdimir]

Changelog category (leave one):

• Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

• Clean moving parts that was merged or mutated during move

TODO:

• Try to add stress tests. I managed to reproduce locally but not sure if tests would be stable enough and what to check (probably system.remote_data_paths)

[robot-ch-test-poll1]

This is an automated comment for commit ac63861 with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🔴 failure

Check name	Description	Status
AST fuzzer	Runs randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help	🟢 success
Bugfix validate check	Checks that either a new test (functional or integration) or there some changed tests that fail with the binary built on master branch	🟢 success
CI running	A meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR	🟢 success
ClickHouse build check	Builds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process	🟢 success
Compatibility check	Checks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help	🟢 success
Docker image for servers	The check to build and optionally push the mentioned image to docker hub	🟢 success
Fast test	Normally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here	🟢 success
Flaky tests	Checks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc	🟢 success
Install packages	Checks that the built packages are installable in a clear environment	🟢 success
Integration tests	The integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests	🟢 success
Mergeable Check	Checks if all other necessary checks are successful	🟢 success
Performance Comparison	Measure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests	🟢 success
Push to Dockerhub	The check for building and pushing the CI related docker images to docker hub	🟢 success
SQLancer	Fuzzing tests that detect logical bugs with SQLancer tool	🟢 success
Sqllogic	Run clickhouse on the sqllogic test set against sqlite and checks that all statements are passed	🟢 success
Stateful tests	Runs stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	🟢 success
Stateless tests	Runs stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	🔴 failure
Stress test	Runs stateless functional tests concurrently from several clients to detect concurrency-related errors	🟢 success
Style Check	Runs a set of checks to keep the code style clean. If some of tests failed, see the related log from the report	🟢 success
Unit tests	Runs the unit tests for different release types	🟢 success
Upgrade check	Runs stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts	🟢 success

[tavplubix]

Does/should data_part_directory include moving/?

[tavplubix]

Let's set temporary_directories_lifetime to 1 in tests for background moves

[vdimir]

Does/should data_part_directory include moving/?

Yes, since we lock part in moving directory before it's renamed.

cloned_part_storage = part->makeCloneOnDisk(disk, MergeTreeData::MOVING_DIR_NAME);

Let's set temporary_directories_lifetime to 1 in tests for background moves

Added to some integration tests, for stateless already set

ClickHouse/tests/config/config.d/merge_tree_old_dirs_cleanup.xml

Line 4 in a84eba6

<temporary_directories_lifetime>1</temporary_directories_lifetime>

[vdimir]

Holder should accept only base name of the part

ClickHouse/src/Storages/MergeTree/MergeTreeData.cpp

Line 2095 in 5d0522c

if (temporary_parts.contains(basename))

Issue found by https://s3.amazonaws.com/clickhouse-test-reports/50489/f28c4dd58f600624a07e2c395b4114a8eb8a4272/integration_tests_flaky_check__asan_.html, fixed

[tavplubix]

We should hold the temp dir lock until the part is renamed to persistent name (renameTo in swapClonedPart)

[vdimir]

Fixed couple of things:

• One found in flaky check https://s3.amazonaws.com/clickhouse-test-reports/50489/f28c4dd58f600624a07e2c395b4114a8eb8a4272/integration_tests_flaky_check__asan_.html

getTemporaryPartDirectoryHolder should accept only basename and also should be taken earlier, before makeCloneOnDisk is called.

• Also part was deleted only in clearOldParts but not in descrtuctor because of this check

ClickHouse/src/Storages/MergeTree/IMergeTreeDataPart.cpp

Lines 501 to 507 in 5d0522c

	if (!startsWith(file_name, "tmp") && !endsWith(file_name, ".tmp_proj"))
	{
	LOG_ERROR(
	storage.log,
	"~DataPart() should remove part {} but its name doesn't start with \"tmp\" or end with \".tmp_proj\". Too "
	"suspicious, keeping the part.",
	path);

Adjusted check to include parts from moving/

• Also added test, locally works fine, let's check in flaky check

[vdimir]

Is it fine to ignore/retry such an error?

[CheSema]

Does this solve it? #49197

[vdimir]

@CheSema yes, your description is exactly the same

[vdimir]

I added to test case with replicated merge tree and check for a content of table. Locally it passes in release/debug both with minio and aws s3. Waiting for CI results...

[vdimir]

I added a config parameter (<allow_remove_stale_moving_parts>) to enable cleanup only if it's set. Let's merge the PR and wait for a couple of weeks if everything is alright in CI, then we will enable it.