New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix segfault in MathUnary #51499
Fix segfault in MathUnary #51499
Conversation
This is an automated comment for commit 32d00dc with description of existing statuses. It's updated for the latest CI running
|
@@ -154,6 +154,8 @@ class FunctionMathUnary : public IFunction | |||
using ColVecType = ColumnVectorOrDecimal<Type>; | |||
|
|||
const auto col_vec = checkAndGetColumn<ColVecType>(col.column.get()); | |||
if (col_vec == nullptr) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will prevent the crash but the true problem is further up the stack, I guess.
+ needs a test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently building binary to canonize the test. But I agree that we need to find root cause.
It looks we do not fail/retry when we could not connect
|
|
Backport #51499 to 23.3: Fix segfault in MathUnary
Backport #51499 to 23.4: Fix segfault in MathUnary
Backport #51499 to 23.5: Fix segfault in MathUnary
Backport #51499 to 22.8: Fix segfault in MathUnary
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Check for incorrect column conversion. Closes #51495.
Documentation entry for user-facing changes