Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix async insert with deduplication for ReplicatedMergeTree using merging algorithms #51676

Merged
merged 7 commits into from Jul 1, 2023

Conversation

antonio2368
Copy link
Member

@antonio2368 antonio2368 commented Jun 30, 2023

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix crash when async inserts with deduplication are used for ReplicatedMergeTree tables using a nondefault merging algorithm.

cc @hanfei1991 @alesapin

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-bugfix Pull request with bugfix, not backported by default label Jun 30, 2023
@robot-clickhouse-ci-1
Copy link
Contributor

robot-clickhouse-ci-1 commented Jun 30, 2023

This is an automated comment for commit 4f59261 with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🟡 pending

Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR🟡 pending
Mergeable CheckChecks if all other necessary checks are successful🟢 success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub🟢 success

@antonio2368 antonio2368 merged commit 3e8358e into master Jul 1, 2023
9 of 11 checks passed
@antonio2368 antonio2368 deleted the fix-async-insert-dedup-for-merging-algorithms branch July 1, 2023 19:08
@tavplubix tavplubix added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label Aug 29, 2023
robot-clickhouse added a commit that referenced this pull request Aug 29, 2023
…icatedMergeTree using merging algorithms
robot-clickhouse added a commit that referenced this pull request Aug 29, 2023
…icatedMergeTree using merging algorithms
robot-clickhouse added a commit that referenced this pull request Aug 29, 2023
…icatedMergeTree using merging algorithms
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Aug 29, 2023
antonio2368 added a commit that referenced this pull request Aug 30, 2023
Backport #51676 to 23.5: Fix async insert with deduplication for ReplicatedMergeTree using merging algorithms
antonio2368 added a commit that referenced this pull request Aug 30, 2023
Backport #51676 to 23.3: Fix async insert with deduplication for ReplicatedMergeTree using merging algorithms
antonio2368 added a commit that referenced this pull request Sep 4, 2023
Backport #51676 to 23.6: Fix async insert with deduplication for ReplicatedMergeTree using merging algorithms
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud pr-bugfix Pull request with bugfix, not backported by default pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-cloud
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants