Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #54430 to 23.3: reproduce and fix the bug in removeSharedRecursive #54536

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

robot-ch-test-poll
Copy link
Contributor

Original pull-request #54430
Cherry-pick pull-request #54521

This pull-request is a last step of an automated backporting.
Treat it as a standard pull-request: look at the checks and resolve conflicts.
Merge it only if you intend to backport changes to the target branch, otherwise just close it.

@robot-ch-test-poll robot-ch-test-poll added the pr-backport Changes, backported to release branch. Do not use manually - automated use only! label Sep 12, 2023
@robot-ch-test-poll4
Copy link
Contributor

robot-ch-test-poll4 commented Sep 12, 2023

This is an automated comment for commit 3b6c0a3 with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🔴 error

Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR🟢 success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process🟢 success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help🟢 success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub🟢 success
Install packagesChecks that the built packages are installable in a clear environment🟢 success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests🔴 error
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub🟢 success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors🟢 success

@tavplubix tavplubix merged commit fc11217 into 23.3 Sep 14, 2023
41 of 42 checks passed
@tavplubix tavplubix deleted the backport/23.3/54430 branch September 14, 2023 13:47
@Felixoid
Copy link
Member

I try to address it in #54720

@tavplubix
Copy link
Member

Sorry, I thought it was some infrastructure issue. My bad, I should have checked the report.

It's okay to simply revert this backport

@Felixoid
Copy link
Member

23.3 will remain for a long, it's better to backport changes from the master to have it compatible

Good thing, these mocks are in a separate module, so won't conflict with the existing one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-backport Changes, backported to release branch. Do not use manually - automated use only!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants