New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug with inability to drop detached partition in replicated merge tree on top of S3 without zero copy #55309
Conversation
… tree on top of S3 without zero copy
This is an automated comment for commit 89294c0 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page Successful checks
|
@alesapin it's a great news to see those fixes. |
|
{ | ||
// Otherwise we will produce lost blobs which nobody points to | ||
/// WriteOnce storages are not affected by the issue | ||
if (!tx->object_storage.isWriteOnce() && tx->metadata_storage.exists(path)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need such changes in DiskObjectStorageTransaction::writeFileUsingBlobWritingFunction
also?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think yes, let's do!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also Unfreezer::removeFreezedPart
has similar branch if (disk->supportZeroCopyReplication())
. Maybe it is worth to fix it too.
…356d283b48eed91adb749cdeb9366 Cherry pick #55309 to 23.9: Fix bug with inability to drop detached partition in replicated merge tree on top of S3 without zero copy
…ition in replicated merge tree on top of S3 without zero copy
Backport #55309 to 23.9: Fix bug with inability to drop detached partition in replicated merge tree on top of S3 without zero copy
…356d283b48eed91adb749cdeb9366 Cherry pick #55309 to 23.8: Fix bug with inability to drop detached partition in replicated merge tree on top of S3 without zero copy
…ition in replicated merge tree on top of S3 without zero copy
…356d283b48eed91adb749cdeb9366 Cherry pick #55309 to 23.7: Fix bug with inability to drop detached partition in replicated merge tree on top of S3 without zero copy
…ition in replicated merge tree on top of S3 without zero copy
Backport #55309 to 23.7: Fix bug with inability to drop detached partition in replicated merge tree on top of S3 without zero copy
Backport #55309 to 23.8: Fix bug with inability to drop detached partition in replicated merge tree on top of S3 without zero copy
…356d283b48eed91adb749cdeb9366 Cherry pick #55309 to 23.3: Fix bug with inability to drop detached partition in replicated merge tree on top of S3 without zero copy
…ition in replicated merge tree on top of S3 without zero copy
Backport #55309 to 23.3: Fix bug with inability to drop detached partition in replicated merge tree on top of S3 without zero copy
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix an issue with inability to drop detached partition in
ReplicatedMergeTree
engines family on top of S3 (without zero-copy replication). Fixes issue #55225. Fix bug with abandoned blobs on S3 for complex data types like Arrays or Nested columns. Partially fixes #52393. Many kudos to @alifirat for examples.