New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove existing moving/ dir if allow_remove_stale_moving_parts is off #55480
Conversation
This is an automated comment for commit d3f9145 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page Successful checks
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
allow_remove_stale_moving_parts = false
is not a default behavior and it's undocumented flag not intended to be changed, so I suppose we can have old behavior if someone really need it
00002_log_and_exception_messages_formatting
|
…c5766459c0c24f6574d11a61c6667 Cherry pick #55480 to 23.3: Remove existing moving/ dir if allow_remove_stale_moving_parts is off
…stale_moving_parts is off
…c5766459c0c24f6574d11a61c6667 Cherry pick #55480 to 23.7: Remove existing moving/ dir if allow_remove_stale_moving_parts is off
…stale_moving_parts is off
…c5766459c0c24f6574d11a61c6667 Cherry pick #55480 to 23.8: Remove existing moving/ dir if allow_remove_stale_moving_parts is off
…stale_moving_parts is off
…c5766459c0c24f6574d11a61c6667 Cherry pick #55480 to 23.9: Remove existing moving/ dir if allow_remove_stale_moving_parts is off
…stale_moving_parts is off
Backport #55480 to 23.3: Remove existing moving/ dir if allow_remove_stale_moving_parts is off
Backport #55480 to 23.9: Remove existing moving/ dir if allow_remove_stale_moving_parts is off
Backport #55480 to 23.7: Remove existing moving/ dir if allow_remove_stale_moving_parts is off
Backport #55480 to 23.8: Remove existing moving/ dir if allow_remove_stale_moving_parts is off
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Bring back 22.8 behavior (remove old dir instead of exception) if allow_remove_stale_moving_parts is off.
Documentation entry for user-facing changes
As moving/ dir still exists for some parts even with the setting turned on (so garbage isn't cleaned on startup), it's reasonable to get back old behavior.