Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix filtering by virtual columns with OR filter in query" #55657

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

antonio2368
Copy link
Member

Reverts #55418

Breaks test_system_merges/test.py::test_mutation_simple

@robot-ch-test-poll robot-ch-test-poll added the pr-not-for-changelog This PR should not be mentioned in the changelog label Oct 16, 2023
@robot-ch-test-poll
Copy link
Contributor

robot-ch-test-poll commented Oct 16, 2023

This is an automated comment for commit fb901c2 with description of existing statuses. It's updated for the latest CI running

⏳ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending

@antonio2368 antonio2368 merged commit 6c543c7 into master Oct 16, 2023
41 of 103 checks passed
@antonio2368 antonio2368 deleted the revert-55418-fix-OR branch October 16, 2023 08:51
@alexey-milovidov alexey-milovidov added pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-cloud labels Oct 17, 2023
robot-clickhouse-ci-2 added a commit that referenced this pull request Oct 17, 2023
…865ea2bcb2b5bae5e163531ef6702

Cherry pick #55657 to 23.7: Revert "Fix filtering by virtual columns with OR filter in query"
robot-clickhouse added a commit that referenced this pull request Oct 17, 2023
robot-clickhouse-ci-2 added a commit that referenced this pull request Oct 17, 2023
…865ea2bcb2b5bae5e163531ef6702

Cherry pick #55657 to 23.8: Revert "Fix filtering by virtual columns with OR filter in query"
robot-clickhouse added a commit that referenced this pull request Oct 17, 2023
robot-clickhouse-ci-2 added a commit that referenced this pull request Oct 17, 2023
…865ea2bcb2b5bae5e163531ef6702

Cherry pick #55657 to 23.9: Revert "Fix filtering by virtual columns with OR filter in query"
robot-clickhouse added a commit that referenced this pull request Oct 17, 2023
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Oct 17, 2023
alexey-milovidov added a commit that referenced this pull request Oct 17, 2023
Backport #55657 to 23.9: Revert "Fix filtering by virtual columns with OR filter in query"
alexey-milovidov added a commit that referenced this pull request Oct 17, 2023
Backport #55657 to 23.8: Revert "Fix filtering by virtual columns with OR filter in query"
alexey-milovidov added a commit that referenced this pull request Oct 17, 2023
Backport #55657 to 23.7: Revert "Fix filtering by virtual columns with OR filter in query"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-cloud pr-not-for-changelog This PR should not be mentioned in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants