-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix an error in previous opt: https://github.com/ClickHouse/ClickHouse/pull/59698 #61145
Conversation
This is an automated comment for commit b354d07 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page Successful checks
|
How did the error manifestate? |
The modified loop code block was intended to find the non-const column with number type and minimum size to reduce the cost of first filter operation without size_hint . So |
@jsc0218 could you review it? thanks ! |
Failed test seems not related to this pr: https://s3.amazonaws.com/clickhouse-test-reports/61145/b354d07b829a94a43cf6f3867585efac389088c1/stateless_tests__asan__[1_4].html |
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix an error in previeous opt: #59698: remove break to make sure the first filtered column has minimum size cc @jsc0218