Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] subtractXYZ #63251

Merged
merged 2 commits into from
May 6, 2024
Merged

Conversation

Blargian
Copy link
Contributor

@Blargian Blargian commented May 1, 2024

Closes #2017 as part of the project document missing functions and update ones which are insufficiently documented.

This PR makes updates / adds where missing the following functions:

  • subtractDays
  • subtractHours
  • subtractInterval
  • subtractMicroseconds
  • subtractMilliseconds
  • subtractMinutes
  • subtractMonths
  • subtractNanoseconds
  • subtractQuarters
  • subtractSeconds
  • subtractTupleOfIntervals
  • subtractWeeks
  • subtractYears

Changelog category (leave one):

  • Documentation (changelog entry is not required)

@thevar1able thevar1able added the can be tested Allows running workflows for external contributors label May 1, 2024
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-documentation Documentation PRs for the specific code PR label May 1, 2024
@robot-ch-test-poll1
Copy link
Contributor

robot-ch-test-poll1 commented May 1, 2024

This is an automated comment for commit ac98f25 with description of existing statuses. It's updated for the latest CI running

✅ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
A SyncThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR✅ success
Docs checkBuilds and tests the documentation✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
PR CheckThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success

@Blargian Blargian marked this pull request as ready for review May 2, 2024 09:29
@nikitamikhaylov nikitamikhaylov self-assigned this May 6, 2024
@nikitamikhaylov nikitamikhaylov added this pull request to the merge queue May 6, 2024
Merged via the queue into ClickHouse:master with commit d0c71e1 May 6, 2024
20 of 21 checks passed
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-synced-to-cloud The PR is synced to the cloud repo label May 6, 2024
**Parameters**

- `date`: Date / date with time to subtract specified number of years from. [date](../data-types/date.md)/[date32](../data-types/date32.md)/[datetime](../data-types/datetime.md)/[datetime64](../data-types/datetime64.md), [String](../data-types/string.md).
- `x`: Number of years to subtract. [(U)Int*](../data-types/int-uint.md), [float*](../data-types/float.md).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

n or num as variable name would be more idomatic


**Parameters**

- `date`: Date / date with time to subtract specified number of quarters from. [date](../data-types/date.md)/[date32](../data-types/date32.md)/[datetime](../data-types/datetime.md)/[datetime64](../data-types/datetime64.md), [String](../data-types/string.md).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

date --> Date
date32 --> Date32
datetime --> DateTime
datetime64 --> DateTime64

@Blargian
Copy link
Contributor Author

Blargian commented May 6, 2024

@rschu1ze opened PR #63418 to fix above mentioned issues. I will make the same changes on #63266

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
can be tested Allows running workflows for external contributors pr-documentation Documentation PRs for the specific code PR pr-synced-to-cloud The PR is synced to the cloud repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document subtractXYZ functions.
6 participants