Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] update addXYZ functions #63266

Merged
merged 5 commits into from
May 11, 2024
Merged

Conversation

Blargian
Copy link
Contributor

@Blargian Blargian commented May 2, 2024

Closes #2273 as part of the functions project to document all missing functions and/or update functions with insufficient documentation.

This PR either adds or updates:

  • addDays
  • addHours
  • addInterval
  • addMicroseconds
  • addMilliseconds
  • addMinutes
  • addMonths
  • addNanoseconds
  • addQuarters
  • addSeconds
  • addTupleOfIntervals
  • addWeeks
  • addYears

Changelog category (leave one):

  • Documentation (changelog entry is not required)

@Blargian Blargian marked this pull request as ready for review May 2, 2024 14:52
@Blargian Blargian mentioned this pull request May 6, 2024
@Algunenano Algunenano added the can be tested Allows running workflows for external contributors label May 7, 2024
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-documentation Documentation PRs for the specific code PR label May 7, 2024
@robot-clickhouse-ci-2
Copy link
Contributor

robot-clickhouse-ci-2 commented May 7, 2024

This is an automated comment for commit 2f32315 with description of existing statuses. It's updated for the latest CI running

✅ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
A SyncThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR✅ success
Docs checkBuilds and tests the documentation✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
PR CheckThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success

@rschu1ze rschu1ze self-assigned this May 8, 2024
@Blargian
Copy link
Contributor Author

Blargian commented May 8, 2024

I'll fix the relevant parts of subtractXYZ quick - they suffer from the same symptoms.

@rschu1ze rschu1ze added this pull request to the merge queue May 11, 2024
Merged via the queue into ClickHouse:master with commit 3b49ccc May 11, 2024
18 checks passed
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-synced-to-cloud The PR is synced to the cloud repo label May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
can be tested Allows running workflows for external contributors pr-documentation Documentation PRs for the specific code PR pr-synced-to-cloud The PR is synced to the cloud repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs] addXYZ functions
5 participants