Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase open files limit #41345

Merged
merged 2 commits into from
Sep 16, 2022
Merged

Increase open files limit #41345

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ea7907
Increase open files limit
ekonkov Sep 15, 2022
cd0b999
Merge branch 'master' into master
nikitamikhaylov Sep 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions programs/install/Install.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,8 +446,8 @@ int mainEntryClickHouseInstall(int argc, char ** argv)
fs::path ulimits_file = ulimits_dir / fmt::format("{}.conf", user);
fmt::print("Will set ulimits for {} user in {}.\n", user, ulimits_file.string());
std::string ulimits_content = fmt::format(
"{0}\tsoft\tnofile\t262144\n"
"{0}\thard\tnofile\t262144\n", user);
"{0}\tsoft\tnofile\t1048576\n"
"{0}\thard\tnofile\t1048576\n", user);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think nowadays systemd is kind of defacto standard.

And for systemd it is better to use LimitNOFILE=1048576 systemd unit directive.
Yes systemd does interpret /etc/security too, but only if it has been configured with PAM (although I guess all major distributives does so), and limits from the unit (LimitNOFILE, ...) will override these.

And right now limit in systemd is 500K -

ClickHouse/packages/clickhouse-server.service

Line 22 in 79bb44a

LimitNOFILE=500000


fs::create_directories(ulimits_dir);

Expand Down