Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt to fix 'Local: No offset stored message' from Kafka #42391

Merged
merged 3 commits into from
Feb 13, 2023
Merged

Attempt to fix 'Local: No offset stored message' from Kafka #42391

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
75137bc
Attempt to fix 'Local: No offset stored message' from Kafka
filimonov Oct 17, 2022
8e930cb
style
filimonov Oct 18, 2022
384ae94
Merge branch 'master' into filimonov-kafka-Local-No-offset-stored
alexey-milovidov Feb 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/Storages/Kafka/KafkaConsumer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,12 @@ void KafkaConsumer::commit()
}
catch (const cppkafka::HandleException & e)
{
LOG_ERROR(log, "Exception during commit attempt: {}", e.what());
// If there were actually no offsets to commit, return. Retrying won't solve
// anything here
if (e.get_error() == RD_KAFKA_RESP_ERR__NO_OFFSET)
committed = true;
else
LOG_ERROR(log, "Exception during commit attempt: {}", e.what());
}
--max_retries;
}
Expand Down