Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport #46080 to 23.1: Add helping logging to auto-merge script #46201

Merged
merged 1 commit into from
Feb 13, 2023
Merged

Backport #46080 to 23.1: Add helping logging to auto-merge script #46201

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 12 additions & 1 deletion tests/ci/merge_pr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,13 @@ def is_approved(self, team: List[NamedUser]) -> bool:
logging.info("There aren't reviews for PR #%s", self.pr.number)
return False

logging.info(
"The following users have reviewed the PR:\n %s",
"\n ".join(
f"{user.login}: {review.state}" for user, review in self.reviews.items()
),
)

filtered_reviews = {
user: review
for user, review in self.reviews.items()
Expand Down Expand Up @@ -125,7 +132,11 @@ def is_approved(self, team: List[NamedUser]) -> bool:
return False
return True

logging.info("The PR #%s is not approved", self.pr.number)
logging.info(
"The PR #%s is not approved by any of %s team member",
self.pr.number,
TEAM_NAME,
)
return False


Expand Down