Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #46569 to 22.12: Fix processing Const(LowCardinality) in arrayMap #46678

Merged
merged 1 commit into from
Feb 22, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/Functions/array/FunctionArrayMapped.h
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
#include <Columns/ColumnFunction.h>
#include <Columns/ColumnMap.h>
#include <Columns/ColumnNullable.h>
#include <Columns/ColumnLowCardinality.h>
#include <Columns/IColumn.h>

#include <Common/Exception.h>
Expand Down Expand Up @@ -343,9 +344,15 @@ class FunctionArrayMapped : public IFunction
replicated_column_function->appendArguments(arrays);

auto lambda_result = replicated_column_function->reduce();

/// Convert LowCardinality(T) -> T and Const(LowCardinality(T)) -> Const(T),
/// because we removed LowCardinality from return type of lambda expression.
if (lambda_result.column->lowCardinality())
lambda_result.column = lambda_result.column->convertToFullColumnIfLowCardinality();

if (const auto * const_column = checkAndGetColumnConst<ColumnLowCardinality>(lambda_result.column.get()))
lambda_result.column = const_column->removeLowCardinality();

if (Impl::needBoolean())
{
/// If result column is Nothing or Nullable(Nothing), just create const UInt8 column with 0 value.
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
[2]
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
SELECT arrayMap(x -> (toLowCardinality(1) + 1::Nullable(UInt8)), [1]);