Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid sending nullptr to memcpy in copyStringInArena #48532

Merged
merged 2 commits into from
Apr 7, 2023
Merged

Avoid sending nullptr to memcpy in copyStringInArena #48532

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
67e6335
Fix nullptr to memcpy
antonio2368 Apr 7, 2023
55a999d
Merge branch 'master' into fix-topk-ubsan
antonio2368 Apr 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/Common/SpaceSaving.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,9 @@ struct SpaceSavingArena<StringRef>
{
StringRef emplace(StringRef key)
{
if (!key.data)
return key;

return copyStringInArena(arena, key);
}

Expand Down
1 change: 1 addition & 0 deletions tests/queries/0_stateless/02710_topk_with_empty_array.reference
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
[[]]
1 change: 1 addition & 0 deletions tests/queries/0_stateless/02710_topk_with_empty_array.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
SELECT topK(emptyArrayInt16());