Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

forbid gwpsan in debug mode to rescue stress tests #48804

Merged
merged 2 commits into from
Apr 16, 2023
Merged

forbid gwpsan in debug mode to rescue stress tests #48804

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
862c7b4
forbid gwpsan in debug mode to rescue stress tests
hanfei1991 Apr 15, 2023
fc101a3
Update CMakeLists.txt
hanfei1991 Apr 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,7 +393,11 @@ else()
endif ()

option (ENABLE_GWP_ASAN "Enable Gwp-Asan" ON)
if (NOT OS_LINUX AND NOT OS_ANDROID)
# We use mmap for allocations more heavily in debug builds,
# but GWP-ASan also wants to use mmap frequently,
# and due to a large number of memory mappings,
# it does not work together well.
if ((NOT OS_LINUX AND NOT OS_ANDROID) OR (CMAKE_BUILD_TYPE_UC STREQUAL "DEBUG"))
hanfei1991 marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually this looks odd, since someone may expect from debug build to have as much checks as possible, instead, maybe it is better to disable it in runtime? i.e.

GWP_ASAN_OPTIONS="Enabled=false"

@hanfei1991 what do you think?

set(ENABLE_GWP_ASAN OFF)
endif ()

Expand Down