Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport #49223 to 23.4: Fix race on Outdated parts loading #49272

Merged
merged 1 commit into from May 1, 2023
Merged

Backport #49223 to 23.4: Fix race on Outdated parts loading #49272

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/Storages/MergeTree/MergeTreeData.cpp
View file
Open in desktop
Expand Up @@ -3948,6 +3948,9 @@ void MergeTreeData::forcefullyMovePartToDetachedAndRemoveFromMemory(const MergeT
else
LOG_INFO(log, "Renaming {} to {}_{} and forgetting it.", part_to_detach->getDataPartStorage().getPartDirectory(), prefix, part_to_detach->name);

if (restore_covered)
waitForOutdatedPartsToBeLoaded();

auto lock = lockParts();
bool removed_active_part = false;
bool restored_active_part = false;
Expand Down