Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sorting of sparse columns with large limit #52827

Merged
merged 2 commits into from Aug 1, 2023
Merged

Fix sorting of sparse columns with large limit #52827

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8447a93
fix sorting of sparse columns with large limit
CurtizJ Jul 31, 2023
f13343b
ASD
CurtizJ Jul 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Columns/ColumnSparse.cpp
View file
Open in desktop
Expand Up @@ -439,7 +439,7 @@ void ColumnSparse::compareColumn(const IColumn & rhs, size_t rhs_row_num,
PaddedPODArray<UInt64> * row_indexes, PaddedPODArray<Int8> & compare_results,
int direction, int nan_direction_hint) const
{
if (row_indexes)
if (row_indexes || !typeid_cast<const ColumnSparse *>(&rhs))
{
/// TODO: implement without conversion to full column.
auto this_full = convertToFullColumnIfSparse();
Expand Down
2 changes: 1 addition & 1 deletion src/Processors/Transforms/PartialSortingTransform.cpp
View file
Open in desktop
Expand Up @@ -159,7 +159,7 @@ void PartialSortingTransform::transform(Chunk & chunk)
{
MutableColumnPtr sort_description_threshold_column_updated = raw_block_columns[i]->cloneEmpty();
sort_description_threshold_column_updated->insertFrom(*raw_block_columns[i], min_row_to_compare);
sort_description_threshold_columns_updated[i] = std::move(sort_description_threshold_column_updated);
sort_description_threshold_columns_updated[i] = sort_description_threshold_column_updated->convertToFullColumnIfSparse();
}

sort_description_threshold_columns = std::move(sort_description_threshold_columns_updated);
Expand Down
1 change: 1 addition & 0 deletions tests/queries/0_stateless/02834_sparse_columns_sort_with_limit.reference
View file
Open in desktop
@@ -0,0 +1 @@
65536
12 changes: 12 additions & 0 deletions tests/queries/0_stateless/02834_sparse_columns_sort_with_limit.sql
View file
Open in desktop
@@ -0,0 +1,12 @@
DROP TABLE IF EXISTS t_sparse_sort_limit;

CREATE TABLE t_sparse_sort_limit (date Date, i UInt64, v Int16)
ENGINE = MergeTree ORDER BY (date, i)
SETTINGS ratio_of_defaults_for_sparse_serialization = 0.9;

INSERT INTO t_sparse_sort_limit SELECT '2020-10-10', number % 10, number FROM numbers(100000);
INSERT INTO t_sparse_sort_limit SELECT '2020-10-11', number % 10, number FROM numbers(100000);

SELECT count() FROM (SELECT toStartOfMonth(date) AS d FROM t_sparse_sort_limit ORDER BY -i LIMIT 65536);

DROP TABLE IF EXISTS t_sparse_sort_limit;