Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No virtual columns in system.columns #6406

Merged
merged 2 commits into from Aug 8, 2019
Merged

No virtual columns in system.columns #6406

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e7c7694
Removed virtual columns from system.columns for backward compatibility
alexey-milovidov Aug 8, 2019
cf0fd48
Added a test
alexey-milovidov Aug 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions dbms/src/Storages/System/StorageSystemColumns.cpp
View file
Open in desktop
Expand Up @@ -126,6 +126,9 @@ class ColumnsBlockInputStream : public IBlockInputStream

for (const auto & column : columns)
{
if (column.is_virtual)
continue;

size_t src_index = 0;
size_t res_index = 0;

Expand Down
1 change: 1 addition & 0 deletions dbms/tests/queries/0_stateless/00981_no_virtual_columns_in_system_columns.reference
View file
Open in desktop
@@ -0,0 +1 @@
default merge_ab x UInt8 0 0 0 0 0 0 0
13 changes: 13 additions & 0 deletions dbms/tests/queries/0_stateless/00981_no_virtual_columns_in_system_columns.sql
View file
Open in desktop
@@ -0,0 +1,13 @@
DROP TABLE IF EXISTS merge_a;
DROP TABLE IF EXISTS merge_b;
DROP TABLE IF EXISTS merge_ab;

CREATE TABLE merge_a (x UInt8) ENGINE = StripeLog;
CREATE TABLE merge_b (x UInt8) ENGINE = StripeLog;
CREATE TABLE merge_ab AS merge(currentDatabase(), '^merge_[ab]$');

SELECT * FROM system.columns WHERE database = currentDatabase() AND table = 'merge_ab';

DROP TABLE merge_a;
DROP TABLE merge_b;
DROP TABLE merge_ab;