Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ALTER to LowCardinality was leading to segfault on empty parts #7985

Merged
merged 2 commits into from
Dec 2, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
wait for delete to finish 0
still alive
100
11 changes: 11 additions & 0 deletions dbms/tests/queries/0_stateless/01035_lc_empty_part_bug.sql
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
-- that test is failing on versions <= 19.11.12
DROP TABLE IF EXISTS lc_empty_part_bug;
create table lc_empty_part_bug (id UInt64, s String) Engine=MergeTree ORDER BY id;
insert into lc_empty_part_bug select number as id, toString(rand()) from numbers(100);
alter table lc_empty_part_bug delete where id < 100;
SELECT 'wait for delete to finish', sleep(1);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will make the test flacky.

alter table lc_empty_part_bug modify column s LowCardinality(String);
SELECT 'still alive';
insert into lc_empty_part_bug select number+100 as id, toString(rand()) from numbers(100);
SELECT count() FROM lc_empty_part_bug WHERE not ignore(*);
DROP TABLE IF EXISTS lc_empty_part_bug;