-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ALTER to LowCardinality was leading to segfault on empty parts #7985
Merged
alexey-milovidov
merged 2 commits into
ClickHouse:master
from
filimonov:lc_empty_part_bug
Dec 2, 2019
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
3 changes: 3 additions & 0 deletions
3
dbms/tests/queries/0_stateless/01035_lc_empty_part_bug.reference
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
wait for delete to finish 0 | ||
still alive | ||
100 |
11 changes: 11 additions & 0 deletions
11
dbms/tests/queries/0_stateless/01035_lc_empty_part_bug.sql
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
-- that test is failing on versions <= 19.11.12 | ||
DROP TABLE IF EXISTS lc_empty_part_bug; | ||
create table lc_empty_part_bug (id UInt64, s String) Engine=MergeTree ORDER BY id; | ||
insert into lc_empty_part_bug select number as id, toString(rand()) from numbers(100); | ||
alter table lc_empty_part_bug delete where id < 100; | ||
SELECT 'wait for delete to finish', sleep(1); | ||
alter table lc_empty_part_bug modify column s LowCardinality(String); | ||
SELECT 'still alive'; | ||
insert into lc_empty_part_bug select number+100 as id, toString(rand()) from numbers(100); | ||
SELECT count() FROM lc_empty_part_bug WHERE not ignore(*); | ||
DROP TABLE IF EXISTS lc_empty_part_bug; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will make the test flacky.